From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DB7081F9FE for ; Sun, 25 Jul 2021 00:11:03 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] extindex: improve comment around git->async_wait_all Date: Sun, 25 Jul 2021 00:11:02 +0000 Message-Id: <20210725001103.11638-3-e@80x24.org> In-Reply-To: <20210725001103.11638-1-e@80x24.org> References: <20210725001103.11638-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I found myself tempted to remove this, but it appears impossible due to odd messages which have multiple Message-IDs. --- lib/PublicInbox/ExtSearchIdx.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 2311161e..1c2a9758 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -937,7 +937,9 @@ EOS }; $self->git->cat_async($smsg->{blob}, \&dd_smsg, $dd); } - # need to wait on every single one + # need to wait on every single one @smsg contents can get + # invalidated inside dd_smsg for messages with multiple + # Message-IDs. $self->git->async_wait_all; if (checkpoint_due($sync)) {