unofficial mirror of meta@public-inbox.org
 help / color / Atom feed
* [PATCH] imap: stop_idle: fix parameter parsing :x
@ 2020-06-15  9:17 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-06-15  9:17 UTC (permalink / raw)
  To: meta

stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects.  This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
---
 lib/PublicInbox/IMAP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
 }
 
 sub stop_idle ($$) {
-	my ($self, $ibx);
+	my ($self, $ibx) = @_;
 	my $sock = $self->{sock} or return;
 	my $fd = fileno($sock);
 	delete $IDLERS->{$fd};

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15  9:17 [PATCH] imap: stop_idle: fix parameter parsing :x Eric Wong

unofficial mirror of meta@public-inbox.org

Archives are clonable: git clone --mirror https://yhetil.org/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.public-inbox.meta
	nntp://news.public-inbox.org/inbox.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git