From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 31DBC1F5AE for ; Mon, 15 Jun 2020 09:17:28 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] imap: stop_idle: fix parameter parsing :x Date: Mon, 15 Jun 2020 09:17:28 +0000 Message-Id: <20200615091728.3381-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: stop_idle was a noop when the client issues a "DONE" continuation or just disconnects. This would not have led to a long term memory leak since FDs get closed and reused, anyways, and all of our InboxIdle mappings are keyed by FD. --- lib/PublicInbox/IMAP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm index d4ef6efe..373bffc1 100644 --- a/lib/PublicInbox/IMAP.pm +++ b/lib/PublicInbox/IMAP.pm @@ -351,7 +351,7 @@ sub cmd_idle ($$) { } sub stop_idle ($$) { - my ($self, $ibx); + my ($self, $ibx) = @_; my $sock = $self->{sock} or return; my $fd = fileno($sock); delete $IDLERS->{$fd};