unofficial mirror of gwl-devel@gnu.org
 help / color / mirror / Atom feed
From: Taiju HIGASHI <higashi@taiju.info>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: gwl-devel@gnu.org
Subject: Re: Support for guile-config 0.5
Date: Wed, 01 Jun 2022 23:28:25 +0900	[thread overview]
Message-ID: <87r148e9va.fsf@taiju.info> (raw)
In-Reply-To: <87mtewzg7g.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 01 Jun 2022 15:01:24 +0200")

Hi Ricardo,

Thank you for reviewing.

I'm not confident in them, but I will tell you my thought.

>>          (switch
>>           (name 'output)
>>           (character #\o)
>>           (synopsis "Set LOCATION as output for a workflow")
>> -         (example "LOCATION"))
>> +         (example "LOCATION")
>> +         (default ""))
>
> This makes the “output” switch mandatory, but it’s optional.

The (default (empty)) and the (default "") are different things.
The (default (empty)) is the default value of the switch record default field.
If I don't add that line, that switch will make evaluated as mandatory
because the default field is (empty). [1]

>>          (switch
>>           (name 'engine)
>>           (character #\e)
>> @@ -147,7 +148,6 @@ format) of the specified workflow.")
>>         (list
>>          (argument
>>           (name 'file)
>> -         (optional? #false)
>>           (test file-exists?)
>>           (handler identity)
>>           (example "/path/to/my-workflow.w")))))
>
> And this just makes the file argument optional, but it’s not.

It is not to change the meaning.
The optional field of the argument record has been removed, so if I do
not delete it, thus it will cause an error.

Since the default value of the default field of the argument record is
(empty),  If I want to mandatory an argument record, In case I just
delete the (optional? #f) line. [2]

Sorry if I am wrong.

[1]:
https://gitlab.com/a-sassmannshausen/guile-config/-/blob/6a00702d044663fef6d6d619f4aeb75417e1b10b/config/api.scm#L167
[2]:
https://gitlab.com/a-sassmannshausen/guile-config/-/commit/9c1b1627dee927839049168a1dfc2500955c83a6#7643f2674b06b682eb8c0695dfc8e1c252099b2f

Cheers,
--
taiju


  reply	other threads:[~2022-06-01 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  3:31 Support for guile-config 0.5 Taiju HIGASHI
2022-06-01 13:01 ` Ricardo Wurmus
2022-06-01 14:28   ` Taiju HIGASHI [this message]
2022-06-01 20:29     ` Ricardo Wurmus
2022-06-02  0:52       ` Taiju HIGASHI
2022-06-06 11:23         ` Ricardo Wurmus
2022-06-06 15:25           ` Taiju HIGASHI
2022-07-06  8:36 ` Ricardo Wurmus
2022-07-06  9:54   ` Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.guixwl.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r148e9va.fsf@taiju.info \
    --to=higashi@taiju.info \
    --cc=gwl-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).