From: Ricardo Wurmus <rekado@elephly.net>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: gwl-devel@gnu.org
Subject: Re: Support for guile-config 0.5
Date: Wed, 01 Jun 2022 15:01:24 +0200 [thread overview]
Message-ID: <87mtewzg7g.fsf@elephly.net> (raw)
In-Reply-To: <87ee0ip9sw.fsf@taiju.info>
Hi,
thank you for the patch.
> The `optional` in the configuration specification has been removed and
> `argument` and `switch` are now interpreted as mandatory when `default`
> is `empty`.
The patch looks wrong to me, but maybe I’m just misunderstanding things.
> diff --git a/gwl/config.scm.in b/gwl/config.scm.in
> index 9ab58e5..f789998 100644
> --- a/gwl/config.scm.in
> +++ b/gwl/config.scm.in
> @@ -65,7 +65,6 @@ workflow.")
> (list
> (argument
> (name 'file)
> - (optional? #false)
> (test file-exists?)
> (handler identity)
> (example "/path/to/my-workflow.w"))))
> @@ -95,12 +94,14 @@ workflow.")
> (character #\i)
> (synopsis "Specify workflow input NAME, optionally mapped to FILE")
> (example "NAME[=FILE]")
> + (default "")
> (test string?))
Okay.
> (switch
> (name 'output)
> (character #\o)
> (synopsis "Set LOCATION as output for a workflow")
> - (example "LOCATION"))
> + (example "LOCATION")
> + (default ""))
This makes the “output” switch mandatory, but it’s optional.
> (switch
> (name 'engine)
> (character #\e)
> @@ -147,7 +148,6 @@ format) of the specified workflow.")
> (list
> (argument
> (name 'file)
> - (optional? #false)
> (test file-exists?)
> (handler identity)
> (example "/path/to/my-workflow.w")))))
And this just makes the file argument optional, but it’s not.
--
Ricardo
next prev parent reply other threads:[~2022-06-01 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 3:31 Support for guile-config 0.5 Taiju HIGASHI
2022-06-01 13:01 ` Ricardo Wurmus [this message]
2022-06-01 14:28 ` Taiju HIGASHI
2022-06-01 20:29 ` Ricardo Wurmus
2022-06-02 0:52 ` Taiju HIGASHI
2022-06-06 11:23 ` Ricardo Wurmus
2022-06-06 15:25 ` Taiju HIGASHI
2022-07-06 8:36 ` Ricardo Wurmus
2022-07-06 9:54 ` Taiju HIGASHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtewzg7g.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=gwl-devel@gnu.org \
--cc=higashi@taiju.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).