From: Ricardo Wurmus <rekado@elephly.net>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: gwl-devel@gnu.org
Subject: Re: Support for guile-config 0.5
Date: Wed, 01 Jun 2022 22:29:28 +0200 [thread overview]
Message-ID: <871qw8yvi3.fsf@elephly.net> (raw)
In-Reply-To: <87r148e9va.fsf@taiju.info>
Hi again,
Taiju HIGASHI <higashi@taiju.info> writes:
> I'm not confident in them, but I will tell you my thought.
>
>>> (switch
>>> (name 'output)
>>> (character #\o)
>>> (synopsis "Set LOCATION as output for a workflow")
>>> - (example "LOCATION"))
>>> + (example "LOCATION")
>>> + (default ""))
>>
>> This makes the “output” switch mandatory, but it’s optional.
>
> The (default (empty)) and the (default "") are different things.
> The (default (empty)) is the default value of the switch record default field.
> If I don't add that line, that switch will make evaluated as mandatory
> because the default field is (empty). [1]
Yes, you are right, sorry.
>>> (switch
>>> (name 'engine)
>>> (character #\e)
>>> @@ -147,7 +148,6 @@ format) of the specified workflow.")
>>> (list
>>> (argument
>>> (name 'file)
>>> - (optional? #false)
>>> (test file-exists?)
>>> (handler identity)
>>> (example "/path/to/my-workflow.w")))))
>>
>> And this just makes the file argument optional, but it’s not.
>
> It is not to change the meaning.
> The optional field of the argument record has been removed, so if I do
> not delete it, thus it will cause an error.
You are right. Sorry, I got confused :)
> Since the default value of the default field of the argument record is
> (empty), If I want to mandatory an argument record, In case I just
> delete the (optional? #f) line. [2]
So I guess the only thing I need to check is what to do when the default
value is the empty string. We have some options that have validators.
When the value is the empty string and the validator merely checks that
the value is a string, then we would always pass validation in the
default case.
I’ll play with this some more and try to come up with better input
validation.
Thanks for getting the ball rolling with this patch!
--
Ricardo
next prev parent reply other threads:[~2022-06-01 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 3:31 Support for guile-config 0.5 Taiju HIGASHI
2022-06-01 13:01 ` Ricardo Wurmus
2022-06-01 14:28 ` Taiju HIGASHI
2022-06-01 20:29 ` Ricardo Wurmus [this message]
2022-06-02 0:52 ` Taiju HIGASHI
2022-06-06 11:23 ` Ricardo Wurmus
2022-06-06 15:25 ` Taiju HIGASHI
2022-07-06 8:36 ` Ricardo Wurmus
2022-07-06 9:54 ` Taiju HIGASHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qw8yvi3.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=gwl-devel@gnu.org \
--cc=higashi@taiju.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).