* [bug#47776] [PATCH] import: go: Fix goproxy option argument's format.
@ 2021-04-14 15:00 ` Z572
2021-05-14 10:41 ` bug#47776: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Z572 @ 2021-04-14 15:00 UTC (permalink / raw)
To: 47776
[-- Attachment #1: 0001-import-go-Fix-goproxy-option-argument-s-format.patch --]
[-- Type: text/x-patch, Size: 1756 bytes --]
From e34f281d39f9b1e247fa649a15657da70f2b548d Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Wed, 14 Apr 2021 22:37:50 +0800
Subject: [PATCH] import: go: Fix goproxy option argument's format.
Commit a8b927a562 Added new procedure go-module-available-versions use
'string-append' to GOPROXY, but 'string->symbol' let GOPROXY is a symbol (it
must be a string), which would lead to wrong-type-arg errors in the
'string-append' procedure.
* guix/scripts/import/go.scm (%options)[goproxy]: Remove call to
'string->symbol'.
---
guix/scripts/import/go.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/guix/scripts/import/go.scm b/guix/scripts/import/go.scm
index 04b07f80cc..74e8e60cce 100644
--- a/guix/scripts/import/go.scm
+++ b/guix/scripts/import/go.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2020 Katherine Cox-Buday <cox.katherine.e@gmail.com>
;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2021 Zheng Junjie <873216071@qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -68,9 +69,7 @@ that are not yet in Guix"))
(alist-cons 'recursive #t result)))
(option '(#\p "goproxy") #t #f
(lambda (opt name arg result)
- (alist-cons 'goproxy
- (string->symbol arg)
- (alist-delete 'goproxy result))))
+ (alist-cons 'goproxy arg (alist-delete 'goproxy result))))
(option '("pin-versions") #f #f
(lambda (opt name arg result)
(alist-cons 'pin-versions? #t result)))
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#47776: [PATCH] import: go: Fix goproxy option argument's format.
2021-04-14 15:00 ` Z572
@ 2021-05-14 10:41 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2021-05-14 10:41 UTC (permalink / raw)
To: Z572; +Cc: 47776-done
Hi,
Z572 <873216071@qq.com> skribis:
>>From e34f281d39f9b1e247fa649a15657da70f2b548d Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071@qq.com>
> Date: Wed, 14 Apr 2021 22:37:50 +0800
> Subject: [PATCH] import: go: Fix goproxy option argument's format.
>
> Commit a8b927a562 Added new procedure go-module-available-versions use
> 'string-append' to GOPROXY, but 'string->symbol' let GOPROXY is a symbol (it
> must be a string), which would lead to wrong-type-arg errors in the
> 'string-append' procedure.
>
> * guix/scripts/import/go.scm (%options)[goproxy]: Remove call to
> 'string->symbol'.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 15:00 [bug#47776] [PATCH] import: go: Fix goproxy option argument's format Z572
2021-04-14 15:00 ` Z572
2021-05-14 10:41 ` bug#47776: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.