From: Z572 via Guix-patches via <guix-patches@gnu.org>
To: Peng Mei Yu <pengmeiyu@riseup.net>
Cc: 51441@debbugs.gnu.org
Subject: [bug#51441] [PATCH] substitutes: keep base's uri-path for Properly construct URL.
Date: Fri, 29 Oct 2021 12:33:42 +0800 [thread overview]
Message-ID: <tencent_64A49B42A91659157F393A2BE5B42568B508@qq.com> (raw)
Message-ID: <87a6is4ff8.fsf@qq.com> (raw)
In-Reply-To: <8735ok31lf.fsf@xqzp.net>
Peng Mei Yu <pengmeiyu@riseup.net> writes:
> Hi,
>
> Z572 via Guix-patches via writes:
>
>> @@ -158,7 +159,8 @@ (define (narinfo-request cache-url path)
>> "Return an HTTP request for the narinfo of PATH at CACHE-URL."
>> (let* ((base (string->uri cache-url))
>> (ref (build-relative-ref
>> - #:path (string-append (store-path-hash-part path) ".narinfo")))
>> + #:path (string-append (uri-path base) "/"
>> + (store-path-hash-part path) ".narinfo")))
>> (url (resolve-uri-reference ref base))
>> (headers '((User-Agent . "GNU Guile"))))
>> (build-request url #:method 'GET #:headers headers)))
>> --
>
> It seems that the root cause for the problem is that cache-url lacks a
> trailing slash. Therefore the last path component is stripped from
> `base` when we compute (resolve-uri-reference ref base). So I think
> ensuring cache-url ends with a slash ("/") is a better approach.
Yes, you are right.
--
over
next prev parent reply other threads:[~2021-10-29 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:53 [bug#51441] [PATCH] substitutes: keep base's uri-path for Properly construct URL Z572 via Guix-patches via
2021-10-27 16:37 ` Z572 via Guix-patches via
2021-10-27 16:37 ` Z572 via Guix-patches via
2021-10-29 1:48 ` Z572 via Guix-patches via
2021-10-29 4:18 ` Peng Mei Yu
2021-10-29 4:33 ` Z572 via Guix-patches via [this message]
2021-10-29 4:33 ` Z572 via Guix-patches via
2021-12-11 23:34 ` bug#51441: " Ludovic Courtès
2021-11-10 11:30 ` [bug#51441] " Zhu Zihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_64A49B42A91659157F393A2BE5B42568B508@qq.com \
--to=guix-patches@gnu.org \
--cc=51441@debbugs.gnu.org \
--cc=873216071@qq.com \
--cc=pengmeiyu@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.