* [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor
@ 2022-09-20 4:13 Sughosha via Guix-patches via
2022-09-20 5:14 ` Liliana Marie Prikler
0 siblings, 1 reply; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-09-20 4:13 UTC (permalink / raw)
To: 57944
[-- Attachment #1.1: Type: text/plain, Size: 13 bytes --]
Empty Message
[-- Attachment #1.2: Type: text/html, Size: 24 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gnome-text-editor.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-gnome-text-editor.patch, Size: 2197 bytes --]
From 03391b5eb619e248c4f55b22bd8f54c3866476ae Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:00:58 +0200
Subject: [PATCH 1/2] gnu: Add gnome-text-editor
* gnu/packages/gnome.scm (gnome-text-editor): New variable.
---
gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c8a49040f4..c76b25d968 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5474,6 +5474,44 @@ (define-public gnome-terminal
keyboard shortcuts.")
(license license:gpl3+)))
+(define-public gnome-text-editor
+ (package
+ (name "gnome-text-editor")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-text-editor/"
+ (version-major version)
+ "/"
+ "gnome-text-editor-"
+ version
+ ".tar.xz"))
+ (sha256
+ (base32
+ "1nn53iv2a82kkqkg5jy0bqh2b2wzg7g4a6w8q3qsis5wvj64lvg5"))))
+ (build-system meson-build-system)
+ (native-inputs (list pkg-config
+ cmake
+ gettext-minimal
+ desktop-file-utils
+ appstream-glib
+ `(,glib "bin")
+ `(,gtk "bin")
+ itstool))
+ (inputs (list glib
+ gtk
+ gtksourceview
+ libadwaita
+ enchant))
+ (home-page "https://gitlab.gnome.org/GNOME/gnome-text-editor")
+ (synopsis "Simple text editor")
+ (description
+ "Text Editor is a simple text editor that focuses on session management.
+It works hard to keep track of changes and state even if you quit the
+application. You can come back to your work even if you've never saved it to a
+file.")
+ (license license:gpl3)))
+
(define-public colord-minimal
(package
(name "colord-minimal")
--
2.37.3
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-gnome-console.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-gnome-console.patch, Size: 2056 bytes --]
From 8142d2bc994e1b7cc61ad379f9ce13ee7e274ec0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:08:05 +0200
Subject: [PATCH 2/2] gnu: Add gnome-console
* gnu/packages/gnome.scm (gnome-console): New variable.
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c76b25d968..14e9c36fc6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5411,6 +5411,38 @@ (define-public gnome-sudoku
more fun.")
(license license:gpl2+)))
+(define-public gnome-console
+ (package
+ (name "gnome-console")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-console/"
+ (version-major version)
+ "/"
+ "gnome-console-"
+ version
+ ".tar.xz"))
+ (sha256
+ (base32
+ "0jbh8g3hmc35fy5fbscqf0831xpg1kv66ci9hykpbia4hz0yc9kx"))))
+ (build-system meson-build-system)
+ (native-inputs (list desktop-file-utils
+ appstream-glib
+ `(,glib "bin")
+ gettext-minimal
+ sassc
+ pkg-config
+ cmake-minimal
+ `(,gtk+ "bin")))
+ (inputs (list gtk+ libhandy vte libgtop gsettings-desktop-schemas))
+ (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
+ (synopsis "Simple user-friendly terminal emulator for the GNOME desktop")
+ (description
+ "Console is supposed to be a simple terminal emulator for the average user
+to carry out simple cli tasks and aims to be a ‘core’ app for GNOME/Phosh")
+ (license license:gpl3)))
+
(define-public gnome-terminal
(package
(name "gnome-terminal")
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor
2022-09-20 4:13 [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor Sughosha via Guix-patches via
@ 2022-09-20 5:14 ` Liliana Marie Prikler
2022-09-20 9:12 ` Sughosha via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-09-20 5:14 UTC (permalink / raw)
To: Sughosha, 57944
Hi,
Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:
> + (uri (string-append "mirror://gnome/sources/gnome-
> text-editor/"
> + (version-major version)
> + "/"
> + "gnome-text-editor-"
> + version
> + ".tar.xz"))
The format provided by the pretty-printer is, like, a suggestion.
> + (build-system meson-build-system)
> + (native-inputs (list pkg-config
You're missing arguments here. At the very least #:glib-or-gtk? #t
> + "Text Editor is a simple text editor that focuses on session
> management.
> +It works hard to keep track of changes and state even if you quit
> the
> +application. You can come back to your work even if you've never
> saved it to a
> +file."
You should probably call it GNOME Text Editor. The description is
fairly light on advertisments as far as copypasta descriptions go, so I
won't fault you for that here.
> + (license license:gpl3)))
Should probably be gpl3+.
> + (synopsis "Simple user-friendly terminal emulator for the GNOME
> desktop")
> + (description
> + "Console is supposed to be a simple terminal emulator for the
> average user
> +to carry out simple cli tasks and aims to be a ‘core’ app for
> GNOME/Phosh")
Ehhhhhh... I do want you to cut down on the ads here.
> + (build-system meson-build-system)
> + (native-inputs (list desktop-file-utils
Missing arguments.
> + (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
Dead link is dead.
> + (license license:gpl3)))
Also probably gpl3+.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor
2022-09-20 5:14 ` Liliana Marie Prikler
@ 2022-09-20 9:12 ` Sughosha via Guix-patches via
2022-09-20 11:21 ` Sughosha via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-09-20 9:12 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 57944
[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]
Thanks for reviewing. I made the changes with the corrections. Here are new patches with the fixes. But one thing I am not sure why gpl3+ was suggested, while in the GitLab repository it is mentioned as GNU GPLv3.
------- Original Message -------
Liliana Marie Prikler <liliana.prikler@gmail.com> schrieb am Dienstag, 20. September 2022 um 07:14:
> Hi,
>
> Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:
>
> > + (uri (string-append "mirror://gnome/sources/gnome-
> > text-editor/"
> > + (version-major version)
> > + "/"
> > + "gnome-text-editor-"
> > + version
> > + ".tar.xz"))
>
> The format provided by the pretty-printer is, like, a suggestion.
>
> > + (build-system meson-build-system)
> > + (native-inputs (list pkg-config
>
> You're missing arguments here. At the very least #:glib-or-gtk? #t
>
> > + "Text Editor is a simple text editor that focuses on session
> > management.
> > +It works hard to keep track of changes and state even if you quit
> > the
> > +application. You can come back to your work even if you've never
> > saved it to a
> > +file."
>
> You should probably call it GNOME Text Editor. The description is
> fairly light on advertisments as far as copypasta descriptions go, so I
> won't fault you for that here.
>
> > + (license license:gpl3)))
>
> Should probably be gpl3+.
>
> > + (synopsis "Simple user-friendly terminal emulator for the GNOME
> > desktop")
> > + (description
> > + "Console is supposed to be a simple terminal emulator for the
> > average user
> > +to carry out simple cli tasks and aims to be a ‘core’ app for
> > GNOME/Phosh")
>
> Ehhhhhh... I do want you to cut down on the ads here.
>
> > + (build-system meson-build-system)
> > + (native-inputs (list desktop-file-utils
>
> Missing arguments.
>
> > + (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
>
> Dead link is dead.
>
> > + (license license:gpl3)))
>
> Also probably gpl3+.
>
> Cheers
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gnome-text-editor.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-gnome-text-editor.patch, Size: 2049 bytes --]
From 03391b5eb619e248c4f55b22bd8f54c3866476ae Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:00:58 +0200
Subject: [PATCH 1/2] gnu: Add gnome-text-editor
* gnu/packages/gnome.scm (gnome-text-editor): New variable.
---
gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c8a49040f4..c76b25d968 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5474,6 +5474,44 @@ (define-public gnome-terminal
keyboard shortcuts.")
(license license:gpl3+)))
+(define-public gnome-text-editor
+ (package
+ (name "gnome-text-editor")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-text-editor/"
+ (version-major version) "/"
+ "gnome-text-editor-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1nn53iv2a82kkqkg5jy0bqh2b2wzg7g4a6w8q3qsis5wvj64lvg5"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:glib-or-gtk? #t))
+ (native-inputs (list pkg-config
+ cmake
+ gettext-minimal
+ desktop-file-utils
+ appstream-glib
+ `(,glib "bin")
+ `(,gtk "bin")
+ itstool))
+ (inputs (list gtk gtksourceview libadwaita enchant))
+ (home-page "https://gitlab.gnome.org/GNOME/gnome-text-editor")
+ (synopsis "GNOME text editor")
+ (description
+ "GNOME Text Editor is a simple text editor that focuses on session
+management. It keeps track of changes and state even if you quit the
+application. You can come back to your work even if you've never saved it to a
+file.")
+ (license license:gpl3+)))
+
(define-public colord-minimal
(package
(name "colord-minimal")
--
2.37.3
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-gnome-console.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-gnome-console.patch, Size: 1903 bytes --]
From 8142d2bc994e1b7cc61ad379f9ce13ee7e274ec0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:08:05 +0200
Subject: [PATCH 2/2] gnu: Add gnome-console
* gnu/packages/gnome.scm (gnome-console): New variable.
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c76b25d968..14e9c36fc6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5411,6 +5411,38 @@ (define-public gnome-sudoku
more fun.")
(license license:gpl2+)))
+(define-public gnome-console
+ (package
+ (name "gnome-console")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-console/"
+ (version-major version) "/"
+ "gnome-console-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0jbh8g3hmc35fy5fbscqf0831xpg1kv66ci9hykpbia4hz0yc9kx"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:glib-or-gtk? #t
+ #:configure-flags
+ `("-Dtests=true")))
+ (native-inputs (list `(,glib "bin")
+ gettext-minimal
+ sassc
+ pkg-config
+ `(,gtk+ "bin")
+ desktop-file-utils))
+ (inputs (list gtk+
+ libhandy
+ vte
+ libgtop
+ gsettings-desktop-schemas))
+ (home-page "https://gitlab.gnome.org/GNOME/console")
+ (synopsis "GNOME terminal emulator")
+ (description
+ "Console is a simple terminal emulator for GNOME desktop")
+ (license license:gpl3+)))
+
(define-public gnome-terminal
(package
(name "gnome-terminal")
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor
2022-09-20 9:12 ` Sughosha via Guix-patches via
@ 2022-09-20 11:21 ` Sughosha via Guix-patches via
2022-09-21 18:22 ` bug#57944: " Liliana Marie Prikler
0 siblings, 1 reply; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-09-20 11:21 UTC (permalink / raw)
To: liliana.prikler; +Cc: 57944
[-- Attachment #1.1: Type: text/plain, Size: 67 bytes --]
One more small correction, cmake as native-input was not necessary.
[-- Attachment #1.2: Type: text/html, Size: 67 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gnome-text-editor.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-gnome-text-editor.patch, Size: 2049 bytes --]
From 03391b5eb619e248c4f55b22bd8f54c3866476ae Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:00:58 +0200
Subject: [PATCH 1/2] gnu: Add gnome-text-editor
* gnu/packages/gnome.scm (gnome-text-editor): New variable.
---
gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c8a49040f4..c76b25d968 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5474,6 +5474,44 @@ (define-public gnome-terminal
keyboard shortcuts.")
(license license:gpl3+)))
+(define-public gnome-text-editor
+ (package
+ (name "gnome-text-editor")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-text-editor/"
+ (version-major version) "/"
+ "gnome-text-editor-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1nn53iv2a82kkqkg5jy0bqh2b2wzg7g4a6w8q3qsis5wvj64lvg5"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:glib-or-gtk? #t))
+ (native-inputs (list pkg-config
+ cmake
+ gettext-minimal
+ desktop-file-utils
+ appstream-glib
+ `(,glib "bin")
+ `(,gtk "bin")
+ itstool))
+ (inputs (list gtk gtksourceview libadwaita enchant))
+ (home-page "https://gitlab.gnome.org/GNOME/gnome-text-editor")
+ (synopsis "GNOME text editor")
+ (description
+ "GNOME Text Editor is a simple text editor that focuses on session
+management. It keeps track of changes and state even if you quit the
+application. You can come back to your work even if you've never saved it to a
+file.")
+ (license license:gpl3+)))
+
(define-public colord-minimal
(package
(name "colord-minimal")
--
2.37.3
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-gnome-console.patch --]
[-- Type: text/x-diff; name=0002-gnu-Add-gnome-console.patch, Size: 1903 bytes --]
From 8142d2bc994e1b7cc61ad379f9ce13ee7e274ec0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Tue, 20 Sep 2022 06:08:05 +0200
Subject: [PATCH 2/2] gnu: Add gnome-console
* gnu/packages/gnome.scm (gnome-console): New variable.
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c76b25d968..14e9c36fc6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5411,6 +5411,38 @@ (define-public gnome-sudoku
more fun.")
(license license:gpl2+)))
+(define-public gnome-console
+ (package
+ (name "gnome-console")
+ (version "42.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/gnome-console/"
+ (version-major version) "/"
+ "gnome-console-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0jbh8g3hmc35fy5fbscqf0831xpg1kv66ci9hykpbia4hz0yc9kx"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:glib-or-gtk? #t
+ #:configure-flags
+ `("-Dtests=true")))
+ (native-inputs (list `(,glib "bin")
+ gettext-minimal
+ sassc
+ pkg-config
+ `(,gtk+ "bin")
+ desktop-file-utils))
+ (inputs (list gtk+
+ libhandy
+ vte
+ libgtop
+ gsettings-desktop-schemas))
+ (home-page "https://gitlab.gnome.org/GNOME/console")
+ (synopsis "GNOME terminal emulator")
+ (description
+ "Console is a simple terminal emulator for GNOME desktop")
+ (license license:gpl3+)))
+
(define-public gnome-terminal
(package
(name "gnome-terminal")
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-21 18:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 4:13 [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor Sughosha via Guix-patches via
2022-09-20 5:14 ` Liliana Marie Prikler
2022-09-20 9:12 ` Sughosha via Guix-patches via
2022-09-20 11:21 ` Sughosha via Guix-patches via
2022-09-21 18:22 ` bug#57944: " Liliana Marie Prikler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.