From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: Marius Bakke <mbakke@fastmail.com>, 34435@debbugs.gnu.org
Subject: [bug#34435] [PATCH 3/3] gnu: Add kscreenlocker.
Date: Tue, 12 Feb 2019 09:45:41 +0100 [thread overview]
Message-ID: <f8725282-2c34-682b-9264-d1b49bed13d3@crazy-compilers.com> (raw)
In-Reply-To: <20190211151835.18653-3-mbakke@fastmail.com>
Am 11.02.19 um 16:18 schrieb Marius Bakke:
> + (native-inputs
> + `(("extra-cmake-modules" ,extra-cmake-modules)
> + ("pkg-config" ,pkg-config)
> +
Empty line.
> + ("logind" ,elogind) ;optional loginctl support
According to my notes (for 5.13.5) this is a run-time dependency. Why do
we need to list it here and not later in some "service"?
Another thing: I suggest keeping al l Plasma related packages in a
module of it's own. This will help keeping modules small, easy to spot
and easier to maintain.
Otherwise LGTM
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2019-02-12 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 15:16 [bug#34435] [PATCH 0/3] KDE updates Marius Bakke
2019-02-11 15:18 ` [bug#34435] [PATCH 1/3] gnu: KDE: Update to 5.54.0 Marius Bakke
2019-02-11 15:18 ` [bug#34435] [PATCH 2/3] gnu: Add kdecoration Marius Bakke
2019-02-12 8:39 ` Hartmut Goebel
2019-02-11 15:18 ` [bug#34435] [PATCH 3/3] gnu: Add kscreenlocker Marius Bakke
2019-02-12 8:45 ` Hartmut Goebel [this message]
2019-02-12 23:02 ` bug#34435: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8725282-2c34-682b-9264-d1b49bed13d3@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=34435@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.