From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:44367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gtThc-0000KQ-AW
	for guix-patches@gnu.org; Tue, 12 Feb 2019 03:46:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gtTha-0001HN-9z
	for guix-patches@gnu.org; Tue, 12 Feb 2019 03:46:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:45100)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gtThZ-0001Fr-TY
	for guix-patches@gnu.org; Tue, 12 Feb 2019 03:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gtThZ-0000aI-K6
	for guix-patches@gnu.org; Tue, 12 Feb 2019 03:46:01 -0500
Subject: [bug#34435] [PATCH 3/3] gnu: Add kscreenlocker.
Resent-Message-ID: <handler.34435.B34435.15499611462223@debbugs.gnu.org>
References: <20190211151835.18653-1-mbakke@fastmail.com>
	<20190211151835.18653-3-mbakke@fastmail.com>
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
Message-ID: <f8725282-2c34-682b-9264-d1b49bed13d3@crazy-compilers.com>
Date: Tue, 12 Feb 2019 09:45:41 +0100
MIME-Version: 1.0
In-Reply-To: <20190211151835.18653-3-mbakke@fastmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>, 34435@debbugs.gnu.org

Am 11.02.19 um 16:18 schrieb Marius Bakke:
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)
> +

Empty line.


> +       ("logind" ,elogind)        ;optional loginctl support

According to my notes (for 5.13.5) this is a run-time dependency. Why do
we need to list it here and not later in some "service"?

Another thing: I suggest keeping al l Plasma related packages in a
module of it's own. This will help keeping modules small, easy to spot
and easier to maintain.

Otherwise LGTM

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |