all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#48893] [PATCH] New package: ack
@ 2021-06-06 23:51 Ryan Sundberg via Guix-patches via
  2021-06-06 23:58 ` Ryan Sundberg via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2021-06-06 23:51 UTC (permalink / raw)
  To: 48893; +Cc: Ryan Sundberg

ack is a grep-like source code search tool.

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
---
 gnu/packages/search.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 362eb0d95e..a131678936 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2021 Ryan Sundberg <ryan@arctype.co>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,11 +25,12 @@
 
 (define-module (gnu packages search)
   #:use-module ((guix licenses)
-                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
+                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
@@ -50,6 +52,32 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml))
 
+
+(define-public ack
+  (package
+    (name "ack")
+    (version "3.5.0")
+    (source 
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://beyondgrep.com/ack-v" version))
+        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
+    (inputs `(("perl" ,perl)))
+    (build-system copy-build-system)
+    (arguments 
+      `(#:install-plan '(("ack" "bin/ack"))
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'unpack 
+                   (lambda* (#:key source #:allow-other-keys)
+                     (copy-file source "ack")
+                     (chmod "ack" #o0755)
+                     #t)))))
+    (home-page "https://github.com/protojure/protoc-plugin")
+    (synopsis "ack is a grep-like source code search tool.")
+    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
+    (license artistic2.0)))
+
 (define-public xapian
   (package
     (name "xapian")
-- 
2.31.1





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48893] [PATCH] New package: ack
  2021-06-06 23:51 [bug#48893] [PATCH] New package: ack Ryan Sundberg via Guix-patches via
@ 2021-06-06 23:58 ` Ryan Sundberg via Guix-patches via
  2021-06-09  7:12   ` Ryan Sundberg via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2021-06-06 23:58 UTC (permalink / raw)
  To: 48893; +Cc: Ryan Sundberg

ack is a grep-like source code search tool.

(The previous patch had the wrong home-page set.)

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
---
 gnu/packages/search.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 362eb0d95e..e4f48d5906 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2021 Ryan Sundberg <ryan@arctype.co>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,11 +25,12 @@
 
 (define-module (gnu packages search)
   #:use-module ((guix licenses)
-                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
+                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
@@ -50,6 +52,31 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml))
 
+(define-public ack
+  (package
+    (name "ack")
+    (version "3.5.0")
+    (source 
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://beyondgrep.com/ack-v" version))
+        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
+    (inputs `(("perl" ,perl)))
+    (build-system copy-build-system)
+    (arguments 
+      `(#:install-plan '(("ack" "bin/ack"))
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'unpack 
+                   (lambda* (#:key source #:allow-other-keys)
+                     (copy-file source "ack")
+                     (chmod "ack" #o0755)
+                     #t)))))
+    (home-page "https://beyondgrep.com/")
+    (synopsis "ack is a grep-like source code search tool.")
+    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
+    (license artistic2.0)))
+
 (define-public xapian
   (package
     (name "xapian")
-- 
2.31.1





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48893] [PATCH] New package: ack
  2021-06-06 23:58 ` Ryan Sundberg via Guix-patches via
@ 2021-06-09  7:12   ` Ryan Sundberg via Guix-patches via
  2021-06-13 20:46     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2021-06-09  7:12 UTC (permalink / raw)
  To: 48893


[-- Attachment #1.1.1: Type: text/plain, Size: 2838 bytes --]

Revised ack patch per coding standards.

--
Sincerely,
Ryan Sundberg

On 6/6/21 4:58 PM, Ryan Sundberg wrote:
> ack is a grep-like source code search tool.
> 
> (The previous patch had the wrong home-page set.)
> 
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>
> ---
>  gnu/packages/search.scm | 29 ++++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
> index 362eb0d95e..e4f48d5906 100644
> --- a/gnu/packages/search.scm
> +++ b/gnu/packages/search.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
>  ;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
>  ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2021 Ryan Sundberg <ryan@arctype.co>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -24,11 +25,12 @@
>  
>  (define-module (gnu packages search)
>    #:use-module ((guix licenses)
> -                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
> +                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
>    #:use-module (guix utils)
> +  #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system perl)
>    #:use-module (guix build-system python)
> @@ -50,6 +52,31 @@
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xml))
>  
> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source 
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v" version))
> +        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)
> +    (arguments 
> +      `(#:install-plan '(("ack" "bin/ack"))
> +        #:phases
> +        (modify-phases %standard-phases
> +          (replace 'unpack 
> +                   (lambda* (#:key source #:allow-other-keys)
> +                     (copy-file source "ack")
> +                     (chmod "ack" #o0755)
> +                     #t)))))
> +    (home-page "https://beyondgrep.com/")
> +    (synopsis "ack is a grep-like source code search tool.")
> +    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage 
of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
> +    (license artistic2.0)))
> +
>  (define-public xapian
>    (package
>      (name "xapian")
> 

[-- Attachment #1.1.2: 0001-gnu-Add-ack-version-3.5.0.patch --]
[-- Type: text/x-patch, Size: 2610 bytes --]

From fea54a57b5b4e1cdc6bd642ae499fbaafad5cb62 Mon Sep 17 00:00:00 2001
From: Ryan Sundberg <ryan@arctype.co>
Date: Sun, 31 Jan 2021 10:29:47 -0800
Subject: [PATCH] gnu: Add ack version 3.5.0

* gnu/packages/search.scm (ack): New variable.

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
---
 gnu/packages/search.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 362eb0d95e..d523d3f93f 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2021 Ryan Sundberg <ryan@arctype.co>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,11 +25,12 @@
 
 (define-module (gnu packages search)
   #:use-module ((guix licenses)
-                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
+                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
@@ -50,6 +52,32 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml))
 
+(define-public ack
+  (package
+    (name "ack")
+    (version "3.5.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://beyondgrep.com/ack-v" version))
+        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
+    (inputs `(("perl" ,perl)))
+    (build-system copy-build-system)
+    (arguments
+      `(#:install-plan '(("ack" "bin/ack"))
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'unpack
+                   (lambda* (#:key source #:allow-other-keys)
+                     (copy-file source "ack")
+                     (chmod "ack" #o0755)
+                     #t)))))
+    (home-page "https://beyondgrep.com/")
+    (synopsis "Grep-like source code search tool")
+    (description "Ack is designed for programmers with large heterogeneous trees of
+source code, as an alternative to grep.")
+    (license artistic2.0)))
+
 (define-public xapian
   (package
     (name "xapian")
-- 
2.31.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48893] [PATCH] New package: ack
  2021-06-09  7:12   ` Ryan Sundberg via Guix-patches via
@ 2021-06-13 20:46     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2021-06-13 20:46 UTC (permalink / raw)
  To: Ryan Sundberg; +Cc: 48893

Hi,

Ryan Sundberg <ryan@arctype.co> skribis:

> From fea54a57b5b4e1cdc6bd642ae499fbaafad5cb62 Mon Sep 17 00:00:00 2001
> From: Ryan Sundberg <ryan@arctype.co>
> Date: Sun, 31 Jan 2021 10:29:47 -0800
> Subject: [PATCH] gnu: Add ack version 3.5.0
>
> * gnu/packages/search.scm (ack): New variable.
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>

Overall this LGTM.  However…

> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v" version))
> +        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)

… I noticed this:

--8<---------------cut here---------------start------------->8---
$ head -4 $(./pre-inst-env guix build ack)/bin/ack
#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl
#
# This file, ack, is generated code.
# Please DO NOT EDIT or send patches for it.
--8<---------------cut here---------------end--------------->8---

Could you arrange so that the ‘ack’ file is “built from source”?
We usually try hard to build everything from source.

Thanks in advance,
Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-13 20:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-06 23:51 [bug#48893] [PATCH] New package: ack Ryan Sundberg via Guix-patches via
2021-06-06 23:58 ` Ryan Sundberg via Guix-patches via
2021-06-09  7:12   ` Ryan Sundberg via Guix-patches via
2021-06-13 20:46     ` Ludovic Courtès

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git