* [bug#60108] [PATCH] gnu: musescore: Fix build.
@ 2022-12-15 23:31 Liliana Marie Prikler
2022-12-15 23:31 ` [bug#60108] [PATCH v2] " Vivien Kraus via Guix-patches via
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Liliana Marie Prikler @ 2022-12-15 23:31 UTC (permalink / raw)
To: 60108; +Cc: Nicolas Goaziou
* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
---
gnu/packages/music.scm | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..0d7fb21701 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
(base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
(modules '((guix build utils)))
(snippet
- ;; Remove unused libraries.
'(begin
+ ;; Remove unused libraries...
(for-each delete-file-recursively
- '("thirdparty/freetype"))))))
+ '("thirdparty/freetype"))
+ ;; ... and precompiled binaries.
+ (delete-file-recursively "src/diagnostics/crashpad_handler")
+ (substitute* "src/diagnostics/CMakeLists.txt"
+ (("install") "#install"))))))
(build-system qt-build-system)
(arguments
`(#:configure-flags
`("-DDOWNLOAD_SOUNDFONT=OFF"
+ "-DBUILD_DIAGNOSTICS=OFF"
"-DMUSESCORE_BUILD_CONFIG=release"
"-DUSE_SYSTEM_FREETYPE=ON")
;; There are tests, but no simple target to run. The command used to
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH v2] gnu: musescore: Fix build.
2022-12-15 23:31 [bug#60108] [PATCH] gnu: musescore: Fix build Liliana Marie Prikler
@ 2022-12-15 23:31 ` Vivien Kraus via Guix-patches via
2022-12-19 17:19 ` Nicolas Goaziou
2022-12-16 17:39 ` [bug#60108] [PATCH] " Nicolas Goaziou
2022-12-18 16:27 ` Vivien Kraus via Guix-patches via
2 siblings, 1 reply; 8+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2022-12-15 23:31 UTC (permalink / raw)
To: 60108; +Cc: Nicolas Goaziou
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
[inputs]: Add qtquickcontrols-5.
---
gnu/packages/music.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..bde01cb312 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
(base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
(modules '((guix build utils)))
(snippet
- ;; Remove unused libraries.
'(begin
+ ;; Remove unused libraries...
(for-each delete-file-recursively
- '("thirdparty/freetype"))))))
+ '("thirdparty/freetype"))
+ ;; ... and precompiled binaries.
+ (delete-file-recursively "src/diagnostics/crashpad_handler")
+ (substitute* "src/diagnostics/CMakeLists.txt"
+ (("install") "#install"))))))
(build-system qt-build-system)
(arguments
`(#:configure-flags
`("-DDOWNLOAD_SOUNDFONT=OFF"
+ "-DBUILD_DIAGNOSTICS=OFF"
"-DMUSESCORE_BUILD_CONFIG=release"
"-DUSE_SYSTEM_FREETYPE=ON")
;; There are tests, but no simple target to run. The command used to
@@ -4825,6 +4830,7 @@ (define-public musescore
qtdeclarative-5
qtgraphicaleffects
qtnetworkauth-5
+ qtquickcontrols-5
qtquickcontrols2-5
qtscript
qtsvg-5
base-commit: 05e4efe0c83c09929d15a0f5faa23a9afc0079e4
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH v2] gnu: musescore: Fix build.
2022-12-15 23:31 ` [bug#60108] [PATCH v2] " Vivien Kraus via Guix-patches via
@ 2022-12-19 17:19 ` Nicolas Goaziou
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2022-12-19 17:19 UTC (permalink / raw)
To: 60108; +Cc: 60108-done, Vivien Kraus
Hello,
Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:
> From: Liliana Marie Prikler <liliana.prikler@gmail.com>
>
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
> [inputs]: Add qtquickcontrols-5.
Thanks to you both.
I added Vivien as a co-author and applied the patch. I'm closing this
issue. Feel free to re-open it if you think something is missing.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH] gnu: musescore: Fix build.
2022-12-15 23:31 [bug#60108] [PATCH] gnu: musescore: Fix build Liliana Marie Prikler
2022-12-15 23:31 ` [bug#60108] [PATCH v2] " Vivien Kraus via Guix-patches via
@ 2022-12-16 17:39 ` Nicolas Goaziou
2022-12-18 16:27 ` Vivien Kraus via Guix-patches via
2 siblings, 0 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2022-12-16 17:39 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 60108
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
FWIW, qa.guix.gnu.org says it looks good to it.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH] gnu: musescore: Fix build.
2022-12-15 23:31 [bug#60108] [PATCH] gnu: musescore: Fix build Liliana Marie Prikler
2022-12-15 23:31 ` [bug#60108] [PATCH v2] " Vivien Kraus via Guix-patches via
2022-12-16 17:39 ` [bug#60108] [PATCH] " Nicolas Goaziou
@ 2022-12-18 16:27 ` Vivien Kraus via Guix-patches via
2022-12-18 20:12 ` Vivien Kraus via Guix-patches via
2 siblings, 1 reply; 8+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2022-12-18 16:27 UTC (permalink / raw)
To: 60108
I tried this patch, but unfortunately MuseScore crashes on startup,
saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
module "QtQuick.Dialogs" is not installed
I checked the source, and QtQuick.Dialogs is indeed imported in a bunch
of QML files.
I don’t know much about qt, so I’m not sure how to proceed. I tried to
copy the package for qtquick-controls to qtquick-dialogs, but guix
can’t find any source for that.
Best regards,
Vivien
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH] gnu: musescore: Fix build.
2022-12-18 16:27 ` Vivien Kraus via Guix-patches via
@ 2022-12-18 20:12 ` Vivien Kraus via Guix-patches via
2022-12-19 15:40 ` Nicolas Goaziou
0 siblings, 1 reply; 8+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2022-12-18 20:12 UTC (permalink / raw)
To: 60108
Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
> I tried this patch, but unfortunately MuseScore crashes on startup,
> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
> module "QtQuick.Dialogs" is not installed
Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the issue :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH] gnu: musescore: Fix build.
2022-12-18 20:12 ` Vivien Kraus via Guix-patches via
@ 2022-12-19 15:40 ` Nicolas Goaziou
2022-12-19 16:52 ` Vivien Kraus via Guix-patches via
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2022-12-19 15:40 UTC (permalink / raw)
To: 60108; +Cc: vivien
Hello,
Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:
> Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
>> I tried this patch, but unfortunately MuseScore crashes on startup,
>> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
>> module "QtQuick.Dialogs" is not installed
>
> Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the
> issue :)
Would you mind sending a patch including this, so that we can apply it
and close the issue?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#60108] [PATCH] gnu: musescore: Fix build.
2022-12-19 15:40 ` Nicolas Goaziou
@ 2022-12-19 16:52 ` Vivien Kraus via Guix-patches via
0 siblings, 0 replies; 8+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2022-12-19 16:52 UTC (permalink / raw)
To: mail, 60108
Le lundi 19 décembre 2022 à 16:40 +0100, Nicolas Goaziou a écrit :
> Would you mind sending a patch including this, so that we can apply
> it
> and close the issue?
I think I messed things up and the original "From:" header is now in
the commit message, sorry.
Can you fix it on your end? I’m not sure I know how to keep the patch
author information while still being able to send it.
Vivien
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-19 17:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 23:31 [bug#60108] [PATCH] gnu: musescore: Fix build Liliana Marie Prikler
2022-12-15 23:31 ` [bug#60108] [PATCH v2] " Vivien Kraus via Guix-patches via
2022-12-19 17:19 ` Nicolas Goaziou
2022-12-16 17:39 ` [bug#60108] [PATCH] " Nicolas Goaziou
2022-12-18 16:27 ` Vivien Kraus via Guix-patches via
2022-12-18 20:12 ` Vivien Kraus via Guix-patches via
2022-12-19 15:40 ` Nicolas Goaziou
2022-12-19 16:52 ` Vivien Kraus via Guix-patches via
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.