* [bug#57419] [PATCH] gnu: add python-grid5000
@ 2022-08-25 20:30 matthieu.simonin
2022-08-29 16:09 ` Marius Bakke
2022-08-30 9:00 ` matthieu.simonin
0 siblings, 2 replies; 4+ messages in thread
From: matthieu.simonin @ 2022-08-25 20:30 UTC (permalink / raw)
To: 57419; +Cc: msimonin
From: msimonin <matthieu.simonin@inria.fr>
---
gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index d060d5b27c..2fea8cfcb0 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -7786,3 +7786,28 @@ (define-public python-whatthepatch
(description
"This package provides a library to parse and apply patches.")
(license license:expat)))
+
+(define-public python-grid5000
+ (package
+ (name "python-grid5000")
+ (version "1.2.3")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.inria.fr/msimonin/python-grid5000")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ "097pm8b68ihk29xz9zv29b1x0bhgjb4lfj8zxk2grbsh7wr9dipg")))
+ (build-system python-build-system)
+ (native-inputs (list python-wheel))
+ (propagated-inputs (list python-requests python-ipython python-pyyaml))
+ (arguments
+ (list #:tests? #f))
+ (home-page "https://pypi.org/project/python-grid5000/")
+ (synopsis "Grid5000 python client")
+ (description
+ "python-grid5000 is a python package wrapping the Grid5000 REST API.
+ You can use it as a library in your python project or you can
+ explore the Grid5000 resources interactively using the embedded shell.")
+ (license license:gpl3)))
base-commit: 26ff8a4b733c06b4f38aa1fb1ec6705bf30eae4a
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#57419] [PATCH] gnu: add python-grid5000
2022-08-25 20:30 [bug#57419] [PATCH] gnu: add python-grid5000 matthieu.simonin
@ 2022-08-29 16:09 ` Marius Bakke
2022-08-30 9:00 ` matthieu.simonin
1 sibling, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2022-08-29 16:09 UTC (permalink / raw)
To: matthieu.simonin, 57419; +Cc: msimonin
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
Hi Matthieu,
Welcome to Guix! The patch looks good overall, a few minor questions:
> +(define-public python-grid5000
> + (package
> + (name "python-grid5000")
> + (version "1.2.3")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.inria.fr/msimonin/python-grid5000")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + "097pm8b68ihk29xz9zv29b1x0bhgjb4lfj8zxk2grbsh7wr9dipg")))
> + (build-system python-build-system)
> + (native-inputs (list python-wheel))
> + (propagated-inputs (list python-requests python-ipython python-pyyaml))
> + (arguments
> + (list #:tests? #f))
Can you add a comment stating why tests are disabled?
> + (home-page "https://pypi.org/project/python-grid5000/")
> + (synopsis "Grid5000 python client")
> + (description
> + "python-grid5000 is a python package wrapping the Grid5000 REST API.
> + You can use it as a library in your python project or you can
> + explore the Grid5000 resources interactively using the embedded shell.")
> + (license license:gpl3)))
The LICENSE.txt file says LGPL3, setup.cfg says GPL3. Which is
correct? :-)
Also, unless otherwise noted in the source code (e.g. "version 3 only"),
it should be "gpl3+", i.e. "and any later version".
Can you send an updated patch?
Thanks in advance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#57419] [PATCH] gnu: add python-grid5000
2022-08-25 20:30 [bug#57419] [PATCH] gnu: add python-grid5000 matthieu.simonin
2022-08-29 16:09 ` Marius Bakke
@ 2022-08-30 9:00 ` matthieu.simonin
2022-08-30 16:00 ` bug#57419: " Marius Bakke
1 sibling, 1 reply; 4+ messages in thread
From: matthieu.simonin @ 2022-08-30 9:00 UTC (permalink / raw)
To: 57419; +Cc: msimonin
From: msimonin <matthieu.simonin@inria.fr>
---
gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index df63602236..170e440338 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -7786,3 +7786,28 @@ (define-public python-whatthepatch
(description
"This package provides a library to parse and apply patches.")
(license license:expat)))
+
+(define-public python-grid5000
+ (package
+ (name "python-grid5000")
+ (version "1.2.3")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.inria.fr/msimonin/python-grid5000")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ "097pm8b68ihk29xz9zv29b1x0bhgjb4lfj8zxk2grbsh7wr9dipg")))
+ (build-system python-build-system)
+ (native-inputs (list python-wheel))
+ (propagated-inputs (list python-requests python-ipython python-pyyaml))
+ (arguments
+ (list #:tests? #f)) ; No tests.
+ (home-page "https://pypi.org/project/python-grid5000/")
+ (synopsis "Grid5000 python client")
+ (description
+ "python-grid5000 is a python package wrapping the Grid5000 REST API.
+ You can use it as a library in your python project or you can
+ explore the Grid5000 resources interactively using the embedded shell.")
+ (license license:gpl3+)))
base-commit: 6beadc82df204f315d06ea35f2e232bb32f8e440
--
2.30.2
Thanks Marius for the review,
I'm sending the update.
There are no suitable tests here, and I changed the licence to GPLv3
everywhere.
Let me know if anything else is needed.
Best,
Matt
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#57419: [PATCH] gnu: add python-grid5000
2022-08-30 9:00 ` matthieu.simonin
@ 2022-08-30 16:00 ` Marius Bakke
0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2022-08-30 16:00 UTC (permalink / raw)
To: matthieu.simonin, 57419-done; +Cc: msimonin
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
matthieu.simonin@inria.fr skriver:
> Thanks Marius for the review,
>
> I'm sending the update.
> There are no suitable tests here, and I changed the licence to GPLv3
> everywhere.
>
> Let me know if anything else is needed.
Thanks! I filled in the commit message (noting the new variable in
python-web.scm), and also added a copyright line for you, hope that was
okay.
Pushed in c19a432652f2fb544eaf918fe287aa898748d76c.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-30 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 20:30 [bug#57419] [PATCH] gnu: add python-grid5000 matthieu.simonin
2022-08-29 16:09 ` Marius Bakke
2022-08-30 9:00 ` matthieu.simonin
2022-08-30 16:00 ` bug#57419: " Marius Bakke
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.