all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
@ 2023-07-30 17:51 Cayetano Santos via Guix-patches via
  2023-08-20 21:20 ` Ludovic Courtès
  2023-08-21  7:46 ` [bug#64961] [PATCH v1] " Cayetano Santos via Guix-patches via
  0 siblings, 2 replies; 5+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-07-30 17:51 UTC (permalink / raw)
  To: 64961; +Cc: Cayetano Santos

* gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
---
 gnu/packages/emacs-xyz.scm | 60 ++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 29 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e8d1ac6034..0bd4ff93bc 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32420,35 +32420,37 @@ (define-public emacs-wc-mode
     (license license:gpl3+)))
 
 (define-public emacs-mastodon
-  (package
-    (name "emacs-mastodon")
-    (version "1.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://codeberg.org/martianh/mastodon.el")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "13swcbvwhjl8ksrgzvmfafkgd3iz8znk49bs1n48w3g9qvh097w7"))))
-    (build-system emacs-build-system)
-    (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               ;; Move the source files to the top level, which is included in
-               ;; the EMACSLOADPATH.
-               (add-after 'unpack 'move-source-files
-                 (lambda _
-                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
-                     (for-each (lambda (f)
-                                 (rename-file f (basename f)))
-                               el-files)))))))
-    (propagated-inputs
-     (list emacs-request))
-    (home-page "https://codeberg.org/martianh/mastodon.el")
-    (synopsis "Emacs client for Mastodon")
-    (description "@code{mastodon.el} is an Emacs client for Mastodon, the
+  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
+        (revision "1"))
+    (package
+      (name "emacs-mastodon")
+      (version (git-version "1.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://codeberg.org/martianh/mastodon.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "15cfjny99yw5frdp8nlyazlwgscvfvbinsj0fbdfprxf50k2zjs6"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 ;; Move the source files to the top level, which is included in
+                 ;; the EMACSLOADPATH.
+                 (add-after 'unpack 'move-source-files
+                   (lambda _
+                     (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                       (for-each (lambda (f)
+                                   (rename-file f (basename f)))
+                                 el-files)))))))
+      (propagated-inputs
+       (list emacs-request emacs-ts emacs-persist))
+      (home-page "https://codeberg.org/martianh/mastodon.el")
+      (synopsis "Emacs client for Mastodon")
+      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
 federated microblogging social network.")
     (license license:gpl3+)))
 

base-commit: c173819c8e5235ce02d60b79bd88b10023a7c614
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
  2023-07-30 17:51 [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88 Cayetano Santos via Guix-patches via
@ 2023-08-20 21:20 ` Ludovic Courtès
  2023-08-21  8:01   ` Cayetano Santos via Guix-patches via
  2023-08-21  7:46 ` [bug#64961] [PATCH v1] " Cayetano Santos via Guix-patches via
  1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2023-08-20 21:20 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 64961

Hi Cayetano,

Cayetano Santos <csantosb@inventati.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.

[...]

> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
> +        (revision "1"))
> +    (package
> +      (name "emacs-mastodon")
> +      (version (git-version "1.0.0" revision commit))

Normally we only package releases, unless there’s a good reason to grab
a snapshot, in which case there should be a comment explaining it.

What’s the situation here?

> +      (synopsis "Emacs client for Mastodon")
> +      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
>  federated microblogging social network.")
>      (license license:gpl3+)))

There’s a missing paren here, which made qa.guix unhappy:

  https://qa.guix.gnu.org/issue/64961

:-)

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#64961] [PATCH v1] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
  2023-07-30 17:51 [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88 Cayetano Santos via Guix-patches via
  2023-08-20 21:20 ` Ludovic Courtès
@ 2023-08-21  7:46 ` Cayetano Santos via Guix-patches via
  1 sibling, 0 replies; 5+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-08-21  7:46 UTC (permalink / raw)
  To: 64961; +Cc: Cayetano Santos

* gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
---
 gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e8d1ac6034..192f697efb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32420,37 +32420,39 @@ (define-public emacs-wc-mode
     (license license:gpl3+)))
 
 (define-public emacs-mastodon
-  (package
-    (name "emacs-mastodon")
-    (version "1.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://codeberg.org/martianh/mastodon.el")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "13swcbvwhjl8ksrgzvmfafkgd3iz8znk49bs1n48w3g9qvh097w7"))))
-    (build-system emacs-build-system)
-    (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               ;; Move the source files to the top level, which is included in
-               ;; the EMACSLOADPATH.
-               (add-after 'unpack 'move-source-files
-                 (lambda _
-                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
-                     (for-each (lambda (f)
-                                 (rename-file f (basename f)))
-                               el-files)))))))
-    (propagated-inputs
-     (list emacs-request))
-    (home-page "https://codeberg.org/martianh/mastodon.el")
-    (synopsis "Emacs client for Mastodon")
-    (description "@code{mastodon.el} is an Emacs client for Mastodon, the
+  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
+        (revision "1"))
+    (package
+      (name "emacs-mastodon")
+      (version (git-version "1.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://codeberg.org/martianh/mastodon.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "15cfjny99yw5frdp8nlyazlwgscvfvbinsj0fbdfprxf50k2zjs6"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 ;; Move the source files to the top level, which is included in
+                 ;; the EMACSLOADPATH.
+                 (add-after 'unpack 'move-source-files
+                   (lambda _
+                     (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                       (for-each (lambda (f)
+                                   (rename-file f (basename f)))
+                                 el-files)))))))
+      (propagated-inputs
+       (list emacs-request emacs-ts emacs-persist))
+      (home-page "https://codeberg.org/martianh/mastodon.el")
+      (synopsis "Emacs client for Mastodon")
+      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
 federated microblogging social network.")
-    (license license:gpl3+)))
+	  (license license:gpl3+))))
 
 (define-public emacs-ebdb
   (package

base-commit: c173819c8e5235ce02d60b79bd88b10023a7c614
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
  2023-08-20 21:20 ` Ludovic Courtès
@ 2023-08-21  8:01   ` Cayetano Santos via Guix-patches via
  2023-09-11 21:54     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-08-21  8:01 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 64961


>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo@gnu.org> wrote:

> Hi Cayetano,
>
> Cayetano Santos <csantosb@inventati.org> skribis:
>
>> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
>
> [...]
>
>> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-mastodon")
>> +      (version (git-version "1.0.0" revision commit))
>
> Normally we only package releases, unless there’s a good reason to grab
> a snapshot, in which case there should be a comment explaining it.
>
> What’s the situation here?

Nothing special here, other than the fact that latest stable is from
more than one year ago.

In my opinion, we should debate this question once for ever in a broader
discussion about emacs packages (guix-devel?): what do we package ?
only stables (obsolete packages, see emacs-org-ref) ? always master (we
run after latest commit) ? something in between (current situation) ?

As for now, it is stated that we privilege releases ... except that
emacs-xyz is full of snapshots, and for a good reason (case of magit,
etc.), probably due to releases being too old (author just forgets
releasing).

(By the way. Similar debate comes to using melpa or melpa-stable)

What do you think ?

Cayetano




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
  2023-08-21  8:01   ` Cayetano Santos via Guix-patches via
@ 2023-09-11 21:54     ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-09-11 21:54 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 64961

Hi Cayetano,

Cayetano Santos <csantosb@inventati.org> skribis:

>>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> Hi Cayetano,
>>
>> Cayetano Santos <csantosb@inventati.org> skribis:
>>
>>> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
>>
>> [...]
>>
>>> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
>>> +        (revision "1"))
>>> +    (package
>>> +      (name "emacs-mastodon")
>>> +      (version (git-version "1.0.0" revision commit))
>>
>> Normally we only package releases, unless there’s a good reason to grab
>> a snapshot, in which case there should be a comment explaining it.
>>
>> What’s the situation here?
>
> Nothing special here, other than the fact that latest stable is from
> more than one year ago.

OK.  I went ahead and applied the patch (there’s not a lot at stake in
this case anyway).

> In my opinion, we should debate this question once for ever in a broader
> discussion about emacs packages (guix-devel?): what do we package ?
> only stables (obsolete packages, see emacs-org-ref) ? always master (we
> run after latest commit) ? something in between (current situation) ?

The question’s not really up for debate in that the policy is to choose
releases, unless there’s a good reason not to do so.  But…

> As for now, it is stated that we privilege releases ... except that
> emacs-xyz is full of snapshots, and for a good reason (case of magit,
> etc.), probably due to releases being too old (author just forgets
> releasing).

… you’re right of course.  The situation of Emacs packages is a bit
special I guess, and it would be worth clarifying that somehow.  Please
feel free to launch the discussion on guix-devel!

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-11 21:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-30 17:51 [bug#64961] [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88 Cayetano Santos via Guix-patches via
2023-08-20 21:20 ` Ludovic Courtès
2023-08-21  8:01   ` Cayetano Santos via Guix-patches via
2023-09-11 21:54     ` Ludovic Courtès
2023-08-21  7:46 ` [bug#64961] [PATCH v1] " Cayetano Santos via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.