all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: 26559@debbugs.gnu.org
Subject: bug#26559: [PATCH] build: emacs: Install only a subset of files.
Date: Wed, 26 Apr 2017 19:50:56 +0530	[thread overview]
Message-ID: <ee075e95.AEUAJc4AQSAAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKzU@mailjet.com> (raw)
In-Reply-To: <87shl09pyg.fsf@gmail.com>


In the new patchset, I have cleaned up and removed some of the regexps,
as you suggested. I have also rewritten the logic using `find-files'
rather than with `ftw'.

> Note, however, that 'move-doc' procedure should be adjusted to find
> info in "doc" subdir (for "doc/*.info$" regex).

I don't think the `move-doc' phase needs to be changed. It finds .info
files with `find-files' which is recursive.

> It doesn't look right that these regexps are duplicated in 2 places.
> I'm not very familiar with build systems, but what if the
> 'include'/'exclude' arguments of 'install' procedure would simply be
> empty lists?  I think it wouldn't do harm if you leave these regexps
> only in 'emacs-build' procedure or would it?

I am not too familiar with build systems, but I think the
include/exclude arguments need to be duplicated in two places. For
example, look at arguments #:strip-flags and #:strip-directories in the
`strip' phase of the gnu-build-system. Even there, the default values of
the arguments are repeated in two places.

> I think it would be too much work.  I quickly looked at the emacs
> packages, and I believe that only slime, auctex and yasnippet need to be
> adjusted to include non-standard files.  Of course, there may be other
> packages that I'm not aware of, but they can be fixed later.

I've provided patches for emacs-slime and emacs-auctex packages as
well. I believe I got all the required files, but please check.

As it stands, emacs-yasnippet does not seem to need any changes. But, I
think the package is already broken. It needs a snippets directory
pulled from a git submodule. And, even the current package does not pull
this submodule. So, I believe the yasnippet package is already
broken. But, I don't use yasnippet, and I'm not too sure.

  reply	other threads:[~2017-04-26 14:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170419073525.2357-1-arunisaac@systemreboot.net>
     [not found] ` <cu7o9vsq1m4.fsf@systemreboot.net>
2017-04-19  7:35   ` bug#26559: [PATCH] build: emacs: Install only a subset of files Arun Isaac
2017-04-19  7:43     ` tumashu
2017-04-19  9:23       ` Arun Isaac
2017-04-19  9:57         ` tumashu
2017-04-19 14:26           ` Arun Isaac
2017-04-20  2:26             ` tumashu
2017-04-20  8:43               ` Arun Isaac
2017-04-20 11:50                 ` Alex Kost
2017-04-19  7:55     ` Arun Isaac
2017-04-20 11:39       ` Alex Kost
2017-04-20 12:52         ` Arun Isaac
2017-04-22 19:56           ` Alex Kost
2017-04-26 14:20             ` Arun Isaac [this message]
2017-05-02 10:10               ` Alex Kost
2017-05-04 18:39         ` Arun Isaac
2017-05-21  9:14           ` Alex Kost
2017-05-21 22:25             ` Ludovic Courtès
2017-05-23  0:48             ` Arun Isaac
2017-04-22 19:57     ` Alex Kost
2017-05-14 13:42       ` Arun Isaac
2017-04-26 14:09     ` bug#26559: [PATCH 1/3] " Arun Isaac
2017-05-04 18:35     ` Arun Isaac
2017-04-19  7:48 ` bug#26560: [PATCH] " Arun Isaac
2017-04-19  7:57   ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee075e95.AEUAJc4AQSAAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKzU@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26559@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.