From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NpY-0008Vq-7z for guix-patches@gnu.org; Wed, 26 Apr 2017 10:22:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3NpS-0000Sv-J4 for guix-patches@gnu.org; Wed, 26 Apr 2017 10:22:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3NpS-0000SU-7E for guix-patches@gnu.org; Wed, 26 Apr 2017 10:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d3NpR-0005O1-St for guix-patches@gnu.org; Wed, 26 Apr 2017 10:22:01 -0400 Subject: bug#26559: [PATCH] build: emacs: Install only a subset of files. Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Wed, 26 Apr 2017 19:50:56 +0530 In-reply-to: <87shl09pyg.fsf@gmail.com> References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> <87shl09pyg.fsf@gmail.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26559@debbugs.gnu.org In the new patchset, I have cleaned up and removed some of the regexps, as you suggested. I have also rewritten the logic using `find-files' rather than with `ftw'. > Note, however, that 'move-doc' procedure should be adjusted to find > info in "doc" subdir (for "doc/*.info$" regex). I don't think the `move-doc' phase needs to be changed. It finds .info files with `find-files' which is recursive. > It doesn't look right that these regexps are duplicated in 2 places. > I'm not very familiar with build systems, but what if the > 'include'/'exclude' arguments of 'install' procedure would simply be > empty lists? I think it wouldn't do harm if you leave these regexps > only in 'emacs-build' procedure or would it? I am not too familiar with build systems, but I think the include/exclude arguments need to be duplicated in two places. For example, look at arguments #:strip-flags and #:strip-directories in the `strip' phase of the gnu-build-system. Even there, the default values of the arguments are repeated in two places. > I think it would be too much work. I quickly looked at the emacs > packages, and I believe that only slime, auctex and yasnippet need to be > adjusted to include non-standard files. Of course, there may be other > packages that I'm not aware of, but they can be fixed later. I've provided patches for emacs-slime and emacs-auctex packages as well. I believe I got all the required files, but please check. As it stands, emacs-yasnippet does not seem to need any changes. But, I think the package is already broken. It needs a snippets directory pulled from a git submodule. And, even the current package does not pull this submodule. So, I believe the yasnippet package is already broken. But, I don't use yasnippet, and I'm not too sure. =