all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Wamm K. D" <jaft.r@outlook.com>, 56960@debbugs.gnu.org
Subject: [bug#56960] [PATCH] * gnu: Add siglo.
Date: Thu, 11 Aug 2022 21:00:00 +0200	[thread overview]
Message-ID: <ea744f19-6db3-d1ae-1d10-482aa67c9040@telenet.be> (raw)
In-Reply-To: <BY5PR07MB70295CC0C994E9AF0BCC5300999C9@BY5PR07MB7029.namprd07.prod.outlook.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 751 bytes --]

On 03-08-2022 22:23, Wamm K. D wrote:

See response by other reviewer (though I'm not sure about the 'name' 
thing, if we change the package name it's easy to adjust the url field 
too), and ...

> +    (propagated-inputs (list gtk+))

... why is it propagated?

> +               `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))))))

Using getenv in this way is incorrect when cross-compiling because it 
will look in native-inputs instead of inputs, but correcting that can 
wait until gtk+ is actually cross-compilable (and then we could write a 
convenient procedure for that).

For GUIX_PYTHONPATH, search-path-as-list can be useful (and slightly 
less fragile, as it does not depend on labels).

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2022-08-11 19:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 20:23 [bug#56960] [PATCH] * gnu: Add siglo Wamm K. D
2022-08-11 11:56 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-31 20:44   ` Ludovic Courtès
2022-09-04 22:27     ` Wamm K. D.
2022-08-11 19:00 ` Maxime Devos [this message]
2022-09-26 18:33   ` Wamm K. D.
2023-03-12  2:02     ` Jaft
2023-03-16 10:19       ` Ludovic Courtès
2023-03-17 16:03         ` Jaft
     [not found]         ` <887796113.1601186.1679068986036@mail.yahoo.com>
2023-05-16 17:19           ` Jaft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea744f19-6db3-d1ae-1d10-482aa67c9040@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56960@debbugs.gnu.org \
    --cc=jaft.r@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.