From: Maxime Devos <maximedevos@telenet.be>
To: Morgan.J.Smith@outlook.com, 48767@debbugs.gnu.org
Subject: [bug#48767] [PATCH 3/6] gnu: Add newlib-msp430.
Date: Sun, 26 Sep 2021 18:04:45 +0200 [thread overview]
Message-ID: <e0b7d2e9b6bc8347cad4f2463f63d62199afb073.camel@telenet.be> (raw)
In-Reply-To: <SN6PR05MB40312BC5DD6C91D909E7C1E0C5A69@SN6PR05MB4031.namprd05.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2439 bytes --]
Morgan.J.Smith@outlook.com schreef op zo 26-09-2021 om 10:51 [-0400]:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/embedded.scm (newlib-msp430): New variable.
> ---
> gnu/packages/embedded.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index 7073168b57..49f3eda5fb 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -563,6 +563,41 @@ languages are C and C++.")
> (variable "CROSS_LIBRARY_PATH")
> (files '("msp430-elf/lib"))))))))
>
> +(define-public newlib-msp430
> + (package
> + (name "newlib")
> + (version "2.4.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "ftp://sourceware.org/pub/newlib/newlib-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "01i7qllwicf05vsvh39qj7qp5fdifpvvky0x95hjq39mbqiksnsl"))))
> + (build-system gnu-build-system)
There already is a newlib package: newlib-arm-none-eabi.
Could you use (package (inherit "newlib-msp430") ...) to reduce duplication?
Also, could you
(a) change the name to, say, "newlib-msp430"
or (b) instead of defining a new "newlib" package, keep a single newlib package
and make the architecture-dependent tweaks depend on (%current-target-system)?
such that "newlib@2.4.0" is an unambigious specification (or, at least, not
more ambigious than it was before), usable for "specification->package"?
> + (arguments
> + `(#:out-of-source? #t
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'fix-references-to-/bin/sh
> + (lambda _
> + (substitute* '("libgloss/msp430/Makefile.in"
> + "libgloss/libnosys/Makefile.in"
> + "libgloss/Makefile.in")
> + (("/bin/sh") (which "sh"))))))
This duplication can be removed by inheriting from 'newlib-arm-none-eabi'.
> + #:configure-flags '("--target=msp430-elf")))
I'd suggest adding #:target "msp430-elf" to 'arguments' instead
of setting #:configure-flags directly. That way, guix knows we are
cross-compiling and won't try to run tests and won't try to
run 'ldconfig'.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-26 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210926145155.966-1-Morgan.J.Smith@outlook.com>
2021-09-26 14:51 ` [bug#48767] [PATCH 2/6] gnu: Add gcc-msp430 Morgan.J.Smith
2021-09-26 15:51 ` Maxime Devos
2021-09-26 14:51 ` [bug#48767] [PATCH 3/6] gnu: Add newlib-msp430 Morgan.J.Smith
2021-09-26 16:04 ` Maxime Devos [this message]
2021-09-26 14:51 ` [bug#48767] [PATCH 4/6] gnu: Add msp430-toolchain Morgan.J.Smith
2021-09-26 16:08 ` Maxime Devos
2021-09-26 14:51 ` [bug#48767] [PATCH 5/6] gnu: Add gdb-msp430 Morgan.J.Smith
2021-09-26 16:16 ` Maxime Devos
2021-09-26 14:51 ` [bug#48767] [PATCH 6/6] gnu: Add msp430lib Morgan.J.Smith
2021-09-26 16:31 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b7d2e9b6bc8347cad4f2463f63d62199afb073.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=48767@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.