From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SI/bLv6aUGENowAAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 18:08:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4GZIKv6aUGEfMgAAbx9fmQ (envelope-from ) for ; Sun, 26 Sep 2021 16:08:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 432512D9A9 for ; Sun, 26 Sep 2021 18:08:30 +0200 (CEST) Received: from localhost ([::1]:37880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUWhZ-0006fA-GR for larch@yhetil.org; Sun, 26 Sep 2021 12:08:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUWeE-0003Z5-DX for guix-patches@gnu.org; Sun, 26 Sep 2021 12:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUWeE-0006nE-3Z for guix-patches@gnu.org; Sun, 26 Sep 2021 12:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUWeD-0006Bg-U6 for guix-patches@gnu.org; Sun, 26 Sep 2021 12:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48767] [PATCH 3/6] gnu: Add newlib-msp430. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48767 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com, 48767@debbugs.gnu.org Received: via spool by 48767-submit@debbugs.gnu.org id=B48767.163267230123781 (code B ref 48767); Sun, 26 Sep 2021 16:05:01 +0000 Received: (at 48767) by debbugs.gnu.org; 26 Sep 2021 16:05:01 +0000 Received: from localhost ([127.0.0.1]:38570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUWe9-0006BL-Ni for submit@debbugs.gnu.org; Sun, 26 Sep 2021 12:05:01 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:32858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUWe7-0006BC-6E for 48767@debbugs.gnu.org; Sun, 26 Sep 2021 12:04:56 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id yg4t2500H0mfAB406g4tgq; Sun, 26 Sep 2021 18:04:53 +0200 Message-ID: From: Maxime Devos Date: Sun, 26 Sep 2021 18:04:45 +0200 In-Reply-To: References: <20210926145155.966-1-Morgan.J.Smith@outlook.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-sbycMizYg5JJ2VzGwBNg" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1632672293; bh=PEyI1kFZVw4wDG3HcpeK2xVL8G8U1bns2FjFgAV2eC4=; h=Subject:From:To:Date:In-Reply-To:References; b=Hi+fBNXvFucXuaFE3So9bou4GC1xz5BU264K48ITrENDxIeLFyxNpmF6vhJsdiK6j BItMidTXOrJR14zmu5wJ8YaMfbE/NuqH/36Rlp6xoai0h9GtN7HKhiK2Y1wpJTunlg QhaydHcmfa41ZLXCDyse+DZ7Szvd3TkhvY8q0WkIt2TZCtsrKV0A+el/VLeUCqSrGM c5qE1WgDYmQhnjHaAMvunbIZBrW+SGARlG668TobTP3gFqxs7mwvPFdXL5QmJB5X/v fEvy04BiIZkSiICKfctI0XQfdY+le/OC3Py724t1B+PVAFqF0EQHQ4Bv3sGlTjzzPg UUo+5sGUt1MkA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632672510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PEyI1kFZVw4wDG3HcpeK2xVL8G8U1bns2FjFgAV2eC4=; b=cIRPKDqaG9eF+y8/AgrpatWtLsRSFxVOVJzkbUF+vhqLTlywJoNYb3tym4RhE8x5sSRz1P eofefMsL02lgzVmHLoIhSG8FMGtYfAXrAsbFWyPnpjh3ILOPjBZJ+ls36Lc++I9/4tCdQB k+AXv1cXuz1UGmfZXq/KPatcrzZoeANzHfiPDD9Nlt5vg6Ealm1oikBPLRDzG9bgUQlsa1 OOTEhJP+9h9TlFiyydGy7l3jWun8wtnrPpPS4ElY+EKHtuR9pyTca/iGqg1iVB6m64lYgX PMdGP6746OSM19o8qtLlHdj1eJ5GcPGQCLtn9MJZonCpNogLh8lrje6eDv7TLA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632672510; a=rsa-sha256; cv=none; b=dLP1cz56r0a8pxyt92qxdKQaEd8SZZthS4FlX0DXrHr95Ttdc7ZvnMz3LZyguTu8CuAgHQ Eudk6p9+gHDW+7ZzHJUylc4ATlz6O9DKLjju7eSbiydttxvyKLhKYa6rBeZ/WgdpSJaB+z Fb8YAZtPsQUU4EBjsPfoT2Dv4UxC7QcHY76vzMuODvwZ/SWzmg3f+v+if8qbuzsbCq3JP5 7Uro9U94PxeD4gmUuApLdLsBtsFap4dlzr0SJi5GpSC4Uej0Glb6qIrl/iC7Qcd0o/hsLy hxXcwM//Yi/uD/Pe7xnXbhRsCrfKX11hZSTBqox+AI2kfJUUdjwuJ3DLzz+yoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Hi+fBNXv; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Hi+fBNXv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 432512D9A9 X-Spam-Score: -3.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8ntX/own5zlw --=-sbycMizYg5JJ2VzGwBNg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Morgan.J.Smith@outlook.com schreef op zo 26-09-2021 om 10:51 [-0400]: > From: Morgan Smith >=20 > * gnu/packages/embedded.scm (newlib-msp430): New variable. > --- > gnu/packages/embedded.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) >=20 > diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm > index 7073168b57..49f3eda5fb 100644 > --- a/gnu/packages/embedded.scm > +++ b/gnu/packages/embedded.scm > @@ -563,6 +563,41 @@ languages are C and C++.") > (variable "CROSS_LIBRARY_PATH") > (files '("msp430-elf/lib")))))))) > =20 > +(define-public newlib-msp430 > + (package > + (name "newlib") > + (version "2.4.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "ftp://sourceware.org/pub/newlib/newli= b-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "01i7qllwicf05vsvh39qj7qp5fdifpvvky0x95hjq39mbqiksnsl"))= )) > + (build-system gnu-build-system) There already is a newlib package: newlib-arm-none-eabi. Could you use (package (inherit "newlib-msp430") ...) to reduce duplication= ? Also, could you =20 (a) change the name to, say, "newlib-msp430" or (b) instead of defining a new "newlib" package, keep a single newlib pac= kage and make the architecture-dependent tweaks depend on (%current-target-syste= m)? such that "newlib@2.4.0" is an unambigious specification (or, at least, not more ambigious than it was before), usable for "specification->package"? > + (arguments > + `(#:out-of-source? #t > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-references-to-/bin/sh > + (lambda _ > + (substitute* '("libgloss/msp430/Makefile.in" > + "libgloss/libnosys/Makefile.in" > + "libgloss/Makefile.in") > + (("/bin/sh") (which "sh")))))) This duplication can be removed by inheriting from 'newlib-arm-none-eabi'. > + #:configure-flags '("--target=3Dmsp430-elf"))) I'd suggest adding #:target "msp430-elf" to 'arguments' instead of setting #:configure-flags directly. That way, guix knows we are cross-compiling and won't try to run tests and won't try to run 'ldconfig'. Greetings, Maxime. --=-sbycMizYg5JJ2VzGwBNg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYVCaHRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tOVAP9ifeuzNHMb7yOzDVH/vECNk7dG NVg0DOe3zHmhCi1IwwEA2nqLv/R4G4407Zq1mzu9B2bnzFi2EgVqEaTstb5xdgA= =gb2l -----END PGP SIGNATURE----- --=-sbycMizYg5JJ2VzGwBNg--