[bug#50655] [PATCH] gnu: Add falltergeist.

[bug#50655] [PATCH] gnu: Add falltergeist.

[phodina via Guix-patches via]

* gnu/packages/games.scm (falltergeist): New variable.

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index c39770c260..ca0e46749c 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
       (license license:wtfpl2))))

+(define-public falltergeist
+  (package
+    (name "falltergeist")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/falltergeist/falltergeist")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("sdl" ,(sdl-union (list sdl2
+                                       sdl2-image
+                                       sdl2-mixer)))
+              ("glew" ,glew)
+              ("glm" ,glm)))
+    (synopsis "Opensource crossplatform Fallout 2 game engine")
+    (description "Opensource crossplatform Fallout 2 game engine.  Game data
+should be placed in ~/.local/share/falltergeist.")
+    (home-page "https://falltergeist.org/")
+    (license license:gpl3)))
+
 (define-public foobillard++
   ;; Even though this latest revision is old already, stable release is
   ;; lagging way behind it, and has issues with textures rendering.
--
2.32.0

[bug#50655] [PATCH] gnu: Add falltergeist.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> * gnu/packages/games.scm (falltergeist): New variable.
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c39770c260..ca0e46749c 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
>  characters and lines resulting in a rainbow effect.")
>        (license license:wtfpl2))))
>
> +(define-public falltergeist
> +  (package
> +    (name "falltergeist")
> +    (version "0.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/falltergeist/falltergeist")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))

What’s the reason for disabling tests?

> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("sdl" ,(sdl-union (list sdl2
> +                                       sdl2-image
> +                                       sdl2-mixer)))
> +              ("glew" ,glew)
> +              ("glm" ,glm)))
> +    (synopsis "Opensource crossplatform Fallout 2 game engine")
> +    (description "Opensource crossplatform Fallout 2 game engine.  Game data
> +should be placed in ~/.local/share/falltergeist.")

The description should consist of one or more full sentences (the first
sentence is lacking a subject).  The path should use Texinfo syntax:

  @file{~/.local/share/filltergeist}


> +    (home-page "https://falltergeist.org/")
> +    (license license:gpl3)))

‘license.txt’ says gpl3+.

Could you send an updated patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#50655] [PATCH v2] gnu: Add falltergeist.

[phodina via Guix-patches via]

Hi Xinglu,

here's the updated patch.

I'm not entirely sure about the license though I'm not a lawyer. I checked the file license.txt and it still seems to me as GPL3, don't know how to spot the "or later" -> GPL3+.

--8<---------------cut here---------------start------------->8---

* gnu/packages/games.scm (falltergeist): New variable.

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index c39770c260..7d08fafc13 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
       (license license:wtfpl2))))

+(define-public falltergeist
+  (package
+    (name "falltergeist")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/falltergeist/falltergeist")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ; no tests provided
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("sdl" ,(sdl-union (list sdl2
+                                       sdl2-image
+                                       sdl2-mixer)))
+              ("glew" ,glew)
+              ("glm" ,glm)))
+    (synopsis "Opensource Fallout 2 game engine")
+    (description "This package provides opensource Fallout 2 game engine.
+Game data should be placed in @file{~/.local/share/falltergeist.}")
+    (home-page "https://falltergeist.org/")
+    (license license:gpl3+)))
+
 (define-public foobillard++
   ;; Even though this latest revision is old already, stable release is
   ;; lagging way behind it, and has issues with textures rendering.
--
2.32.0

[bug#50655] [PATCH v2] gnu: Add falltergeist.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]

On Mon, Sep 27 2021, phodina wrote:

> Hi Xinglu,
>
> here's the updated patch.
>
> I'm not entirely sure about the license though I'm not a lawyer. I
> checked the file license.txt and it still seems to me as GPL3, don't
> know how to spot the "or later" -> GPL3+.

On line 637, it says

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

> --8<---------------cut here---------------start------------->8---
>
> * gnu/packages/games.scm (falltergeist): New variable.
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c39770c260..7d08fafc13 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
>  characters and lines resulting in a rainbow effect.")
>        (license license:wtfpl2))))
>
> +(define-public falltergeist
> +  (package
> +    (name "falltergeist")
> +    (version "0.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/falltergeist/falltergeist")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; no tests provided
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("sdl" ,(sdl-union (list sdl2
> +                                       sdl2-image
> +                                       sdl2-mixer)))
> +              ("glew" ,glew)
> +              ("glm" ,glm)))
> +    (synopsis "Opensource Fallout 2 game engine")
> +    (description "This package provides opensource Fallout 2 game engine.
> +Game data should be placed in @file{~/.local/share/falltergeist.}")
> +    (home-page "https://falltergeist.org/")
> +    (license license:gpl3+)))

LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#50655: [PATCH v2] gnu: Add falltergeist.

[Nicolas Goaziou]

Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

> On Mon, Sep 27 2021, phodina wrote:
>
>> here's the updated patch.

Thank you. I removed "opensource" since everything is free in Guix, and pushed.

>
> LGTM!

Thanks for the review.

Regards,
-- 
Nicolas Goaziou