all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 54558-done@debbugs.gnu.org, batalie@riseup.net
Subject: bug#54558: mcomix refuses to run, missing GTK libraries
Date: Sat, 26 Mar 2022 09:01:47 +0100	[thread overview]
Message-ID: <df2c43a767c33a26a76db50b20d6ef73380a5979.camel@gmail.com> (raw)
In-Reply-To: <87czi9xvxl.fsf_-_@gmail.com>

Hi Maxim,

Am Freitag, dem 25.03.2022 um 22:57 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > [...]
> > +              (let ((p7zip (assoc-ref inputs "p7zip")))
> > +                ;; insert absolute path to 7z executable
> 
> I know it's in the original, but since while we're revamping the
> package, let's make this comment a proper complete sentence.
Thanks, did that.

> > +                (substitute* "mcomix/archive/sevenzip_external.py"
> > +                  (("_7z_executable = -1")
> > +                   (string-append "_7z_executable = u'" p7zip
> > "/bin/7z'")))
> 
> I'd use something like:
> 
> (format #f "_7z_executable = ~s"
>  (search-input-file inputs "bin/7z"))
> 
> For the replacement.  That unicode string (u"something") is
> obsolete/unnecessary (all strings are unicode in Python 3).
Thanks, did that.

> I haven't tried it, but LGTM with my above comments addressed.
I tried it in a pure shell and apart from the usual missing icons, it
launched fine.  Closing.

Cheers




  reply	other threads:[~2022-03-26  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 20:08 bug#54558: mcomix refuses to run, missing GTK libraries Natalie
2022-03-25 20:37 ` bug#54558: [PATCH 1/2] gnu: mcomix: Update to 2.0.1 Liliana Marie Prikler
2022-03-26  2:57   ` bug#54558: mcomix refuses to run, missing GTK libraries Maxim Cournoyer
2022-03-26  8:01     ` Liliana Marie Prikler [this message]
2022-03-25 22:45 ` bug#54558: [PATCH 2/2] gnu: mcomix: Wrap missing paths Liliana Marie Prikler
2022-03-27  2:26 ` bug#54558: Mcomix 2.0.1 do not install locale data Feng Shu
2022-03-27  9:39   ` Feng Shu
2022-03-27  9:52     ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df2c43a767c33a26a76db50b20d6ef73380a5979.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=54558-done@debbugs.gnu.org \
    --cc=batalie@riseup.net \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.