[bug#62078] [PATCH] gnu: Add python-redo.

[bug#62078] [PATCH] gnu: Add python-redo.

[Adam Faiz via Guix-patches via]

 From f22e04ade259930dc3c3e282d044b7b8b6b1f774 Mon Sep 17 00:00:00 2001
Message-Id: <f22e04ade259930dc3c3e282d044b7b8b6b1f774.1678379861.git.adam.faiz@disroot.org>
In-Reply-To: <f788ce8ebc205a6e05bcc270865d793d94bf51e9.1678379861.git.adam.faiz@disroot.org>
References: <f788ce8ebc205a6e05bcc270865d793d94bf51e9.1678379861.git.adam.faiz@disroot.org>
From: AwesomeAdam54321 <adam.faiz@disroot.org>
Date: Thu, 9 Mar 2023 21:59:48 +0800
Subject: [PATCH] gnu: Add python-redo.

* gnu/packages/python-xyz.scm (python-redo): New variable.
---
  gnu/packages/python-xyz.scm | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4bacd86432..d4f0a83a5d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3595,6 +3595,23 @@ (define-public python-miniupnpc
      (home-page "http://miniupnp.free.fr")
      (license license:bsd-3)))
  
+(define-public python-redo
+  (package
+    (name "python-redo")
+    (version "2.0.4")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "redo" version))
+              (sha256
+               (base32
+                "0hx0yyl2mz13v513vyjc3h9lbkkxhyh6bswich73p18w0ianj1l1"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/mozilla-releng/redo")
+    (synopsis "Utilities to retry Python callables")
+    (description "Redo provides various means to add seamless ability to
+retry to any Python callable.")
+    (license license:mpl2.0)))
+
  (define-public python-py
    (package
      (name "python-py")
-- 
2.39.2

[bug#62078] [PATCH] gnu: Add python-redo.

[jgart via Guix-patches via]

Hi Adam,

Thanks for the patch!

Could you send an updated patch (v2) enabling the tests on python-redo and adding any test inputs that are required for that?

This current patch also does not apply cleanly to master:

error: corrupt patch at line 33
Patch failed at 0001 gnu: Add python-redo.

all best,

jgart

[bug#62078] [PATCH v2] gnu: Add python-redo.

[Adam Faiz via Guix-patches via]

 From 971c628998b36dc32bafd30364f635bafc8ff7cd Mon Sep 17 00:00:00 2001
Message-Id: <971c628998b36dc32bafd30364f635bafc8ff7cd.1685764335.git.adam.faiz@disroot.org>
From: AwesomeAdam54321 <adam.faiz@disroot.org>
Date: Thu, 9 Mar 2023 21:59:48 +0800
Subject: [PATCH v2] gnu: Add python-redo.

* gnu/packages/python-xyz.scm (python-redo): New variable.
---
  gnu/packages/python-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
  1 file changed, 35 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 19f4ec97ff..2e2387a14a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29988,6 +29988,41 @@ (define-public python-recommonmark
  lets you write CommonMark inside of Docutils & Sphinx projects.")
      (license license:expat)))
  
+(define-public python-redo
+  ; The latest release isn't tagged:
+  ; https://github.com/mozilla-releng/redo/issues/76
+  (let ((commit "50cfe8e3656f253f9e51df3a998530351d2d9a8c")
+        (revision "0"))
+    (package
+      (name "python-redo")
+      (version (git-version "2.0.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)               ; no tests in PyPI release
+         (uri (git-reference
+               (url "https://github.com/mozilla-releng/redo")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0xpylx97qr4ikdhsr208ri41007mpp57a4n8mmlmlqmdljmsdpdb"))))
+      (build-system python-build-system)
+      (native-inputs
+       (list python-mock
+             python-pytest))
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 (replace 'check
+                   (lambda* (#:key tests? #:allow-other-keys)
+                     (when tests?
+                       ;; The project uses tox to run the tests via pytest.
+                       (invoke "pytest")))))))
+      (home-page "https://github.com/mozilla-releng/redo")
+      (synopsis "Utilities to retry Python callables")
+      (description "Redo provides various means to add seamless ability to
+retry to any Python callable.")
+      (license license:mpl2.0))))
+
  (define-public python-pyhull
    (package
      (name "python-pyhull")

base-commit: 12e6a5923812abf180f03bea9e07dd99244a3fcd
-- 
2.40.1

[bug#62078] [PATCH v2] gnu: Add python-redo.

[jgart via Guix-patches via]

Hi Adam,

Thanks for sending an update.

How did you take this patch? I'm trying to debug why this patch is not applying cleanly on my end.

I get the following error:

warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: gnu: Add python-redo.
error: corrupt patch at line 51
Patch failed at 0001 gnu: Add python-redo.

all best,

jgart

[bug#62078] [PATCH v2] gnu: Add python-redo.

[jgart via Guix-patches via]

tags 62078 moreinfo

[bug#62078] [PATCH v2] gnu: Add python-redo.

[Adam Faiz via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On 6/4/23 21:14, jgart wrote:
> Hi Adam,
> 
> Thanks for sending an update.
> 
> How did you take this patch? I'm trying to debug why this patch is not applying cleanly on my end.
> 
> I get the following error:
> 
> warning: Patch sent with format=flowed; space at the end of lines might be lost.
> Applying: gnu: Add python-redo.
> error: corrupt patch at line 51
> Patch failed at 0001 gnu: Add python-redo.Sorry for the late reply, the patch doesn't apply cleanly because my email client sent the email with format=flowed.
Attached is a rebased patch on top of master.
  
> all best,
> 
> jgart

[-- Attachment #2: gnu-Add-python-redo.patch --]
[-- Type: text/x-patch, Size: 2336 bytes --]

From 280f9812dbd0330e5656b19c3f818a811b1e7637 Mon Sep 17 00:00:00 2001
Message-Id: <280f9812dbd0330e5656b19c3f818a811b1e7637.1687562979.git.adam.faiz@disroot.org>
From: AwesomeAdam54321 <adam.faiz@disroot.org>
Date: Thu, 9 Mar 2023 21:59:48 +0800
Subject: [PATCH v2] gnu: Add python-redo.

* gnu/packages/python-xyz.scm (python-redo): New variable.
---
 gnu/packages/python-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 799c5652b0..0b0403c0ce 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -30280,6 +30280,41 @@ (define-public python-recommonmark
 lets you write CommonMark inside of Docutils & Sphinx projects.")
     (license license:expat)))
 
+(define-public python-redo
+  ; The latest release isn't tagged:
+  ; https://github.com/mozilla-releng/redo/issues/76
+  (let ((commit "50cfe8e3656f253f9e51df3a998530351d2d9a8c")
+        (revision "0"))
+    (package
+      (name "python-redo")
+      (version (git-version "2.0.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)               ; no tests in PyPI release
+         (uri (git-reference
+               (url "https://github.com/mozilla-releng/redo")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0xpylx97qr4ikdhsr208ri41007mpp57a4n8mmlmlqmdljmsdpdb"))))
+      (build-system python-build-system)
+      (native-inputs
+       (list python-mock
+             python-pytest))
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 (replace 'check
+                   (lambda* (#:key tests? #:allow-other-keys)
+                     (when tests?
+                       ;; The project uses tox to run the tests via pytest.
+                       (invoke "pytest")))))))
+      (home-page "https://github.com/mozilla-releng/redo")
+      (synopsis "Utilities to retry Python callables")
+      (description "Redo provides various means to add seamless ability to
+retry to any Python callable.")
+      (license license:mpl2.0))))
+
 (define-public python-pyhull
   (package
     (name "python-pyhull")

base-commit: f25529b08e356f89ca7cecc44295085531a8faba
-- 
2.40.1

bug#62078: [PATCH] gnu: Add python-redo.

[jgart via Guix-patches via]

Hi Adam,

Thanks for the patch. APPLIED.

all best,

jgart