From: Maxime Devos <maximedevos@telenet.be>
To: Jacob Hrbek <kreyren@rixotstudio.cz>
Cc: 57809@debbugs.gnu.org
Subject: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 23:50:49 +0200 [thread overview]
Message-ID: <d9346de3-50d0-85d3-f033-5c06753e846e@telenet.be> (raw)
In-Reply-To: <P5DFIR.K7JI549PMIPU2@rixotstudio.cz>
[-- Attachment #1.1.1: Type: text/plain, Size: 2314 bytes --]
On 18-09-2022 23:32, Jacob Hrbek wrote:
> On Ne, zář 18 2022 at 23:14:12 +0200, Maxime Devos
> <maximedevos@telenet.be> wrote:
>> I find (search-input-file inputs "/bin/qemu-img") clearer -- 'inputs'
>> / 'native-inputs' is sufficiently complicated on its own, no need to
>> bring %build-inputs and friends in the equation when it can be avoided.
>
> That ain't working for me: https://i.imgur.com/Co4Xsjl.png
> <https://i.imgur.com/Co4Xsjl.png>
Quoting the relevant code would be sufficient, no need for image links.
Besides, text is more accessible than images of text, text would reach
a wider audience.
> unbound-variable #f "Unbound variable: ~S" (native-inputs) #f
(1) 'qemu-minimal' is in the wrong place, it needs to be in 'inputs',
not 'native-inputs', otherwise it is compiled for the wrong
architecture. (In both the phase and the inputs/native-inputs field)
(2) 'native-inputs' (or 'inputs'), is unbound. For information on how
to use search-input-file, inputs and phases, see the manual, in
particular (guix)Build Utilities (index entry: search-input-file) and
its example.
>> (1) the convention is TODO or FIXME, not NOTE It's not: - TODO as in "To Do something" or "for something to be done"
> - FIXME as in "Low priority thing or quality assurance something that
> needs to be fixed"
A missing hardcoded file name can easily be a (usually low-priority)
bug, so FIXME applies, it's also something to investigate and solve (if
appropriate), so TODO applies.
> More like handing over note to the next guy about possible issue in the
> future and leaving the signature here so that they can just go on chat
The required information is already in the "TODO: [stuff about file
names]", they do not need to go 'on chat', and if they do anyway,
hardcoding file names is a relatively well-known solution, so I don't
expect a contact person to be needed.
If that's not sufficient, you can insert an (impersonal) link to the
Guix issue <https://issues.guix.gnu.org/issue/57809>, which has all the
relevant information (which is available even when you aren't available
for chatting, and also when your IRC nick is unknown or if you're gone).
Also, there are no gender restrictions in Guix.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-18 21:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 18:17 [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Jacob Hrbek
2022-09-14 18:18 ` [bug#57810] " Jacob Hrbek
2022-09-15 13:03 ` [bug#57809] " Maxime Devos
2022-09-18 20:43 ` [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path Jacob Hrbek
2022-09-18 21:05 ` Jacob Hrbek
2022-09-18 21:14 ` Maxime Devos
2022-09-18 21:32 ` Jacob Hrbek
2022-09-18 21:50 ` Maxime Devos [this message]
2022-09-19 4:28 ` Jacob Hrbek
2022-09-19 13:35 ` Maxime Devos
2022-09-18 20:46 ` Jacob Hrbek
2022-09-18 20:47 ` [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Jacob Hrbek
2022-09-19 4:09 ` [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path Jacob Hrbek
2022-09-19 13:41 ` Maxime Devos
2022-09-26 21:03 ` bug#57809: [PATCH] gnome-boxes: Add 'qemu' as propagated-input Ludovic Courtès
2022-09-19 21:36 ` [bug#57809] [PATCH] gnome-boxes: Fix path for 'qemu-img' Jacob Hrbek
2022-09-20 5:18 ` Liliana Marie Prikler
2022-09-20 7:55 ` Jacob Hrbek
2022-09-20 17:12 ` Liliana Marie Prikler
2022-09-26 21:07 ` [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9346de3-50d0-85d3-f033-5c06753e846e@telenet.be \
--to=maximedevos@telenet.be \
--cc=57809@debbugs.gnu.org \
--cc=kreyren@rixotstudio.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.