From: Maxime Devos <maximedevos@telenet.be>
To: Jacob Hrbek <kreyren@rixotstudio.cz>, 57809@debbugs.gnu.org
Subject: [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Thu, 15 Sep 2022 15:03:21 +0200 [thread overview]
Message-ID: <706db9e7-4906-525c-5ccb-84580ce71392@telenet.be> (raw)
In-Reply-To: <20220914181624.13204-1-kreyren@rixotstudio.cz>
[-- Attachment #1.1.1: Type: text/plain, Size: 1048 bytes --]
On 14-09-2022 20:17, Jacob Hrbek wrote:
> Fixes:
>
> (gnome-boxes:9304): Boxes-WARNING **: 19:54:29.345: review-page.vala:32: Box setup failed: Failed to create volume: internal error: creation of non-raw file images is not supported without qemu-img.
>
> (gnome-boxes:9304): Boxes-CRITICAL **: 19:54:29.345: boxes_assistant_review_page_populate: assertion 'machine != NULL' failed
>
> Steps to reproduce:
> 1. Open gnome-boxes on GNU Guix
> 2. Try to create a box with GNU Guix ISO and expect failure above
>
>
Instead of propagation, I recommend doing a substitute* instead, to
avoid the usual downsides of propagation. Searching for 'qemu-img' in
the source code of gnome-boxes (with tar, grep -rF and guix build
--source), I found:
src/installed-media.vala: string[] argv = { "qemu-img",
"convert", "-O", "qcow2", device_file, destination_path };
Could you substitute* "qemu-img" -> (search-input-file inputs
"bin/qemu-img") and move QEMU from 'propagated-inputs' to 'inputs'.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-15 13:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 18:17 [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Jacob Hrbek
2022-09-14 18:18 ` [bug#57810] " Jacob Hrbek
2022-09-15 13:03 ` Maxime Devos [this message]
2022-09-18 20:43 ` [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path Jacob Hrbek
2022-09-18 21:05 ` Jacob Hrbek
2022-09-18 21:14 ` Maxime Devos
2022-09-18 21:32 ` Jacob Hrbek
2022-09-18 21:50 ` Maxime Devos
2022-09-19 4:28 ` Jacob Hrbek
2022-09-19 13:35 ` Maxime Devos
2022-09-18 20:46 ` Jacob Hrbek
2022-09-18 20:47 ` [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Jacob Hrbek
2022-09-19 4:09 ` [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path Jacob Hrbek
2022-09-19 13:41 ` Maxime Devos
2022-09-26 21:03 ` bug#57809: [PATCH] gnome-boxes: Add 'qemu' as propagated-input Ludovic Courtès
2022-09-19 21:36 ` [bug#57809] [PATCH] gnome-boxes: Fix path for 'qemu-img' Jacob Hrbek
2022-09-20 5:18 ` Liliana Marie Prikler
2022-09-20 7:55 ` Jacob Hrbek
2022-09-20 17:12 ` Liliana Marie Prikler
2022-09-26 21:07 ` [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=706db9e7-4906-525c-5ccb-84580ce71392@telenet.be \
--to=maximedevos@telenet.be \
--cc=57809@debbugs.gnu.org \
--cc=kreyren@rixotstudio.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.