all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54986@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#54986] [PATCH] gnu: mpd: Add support for socket activation.
Date: Fri, 13 May 2022 19:00:41 +0200	[thread overview]
Message-ID: <d3bb074bff53a0503742b953762ac46de5f0b9cc.camel@gmail.com> (raw)
In-Reply-To: <87ee0xfmvb.fsf_-_@gnu.org>

Am Freitag, dem 13.05.2022 um 17:55 +0200 schrieb Ludovic Courtès:
> Hi Liliana,
> 
> What’s the status of this patch series?  Would be nice to have it in!
The patch for MPD itself is good to go as far as I'm aware, the patch
for the service type is work in progress.

This question
> Ludovic Courtès <ludo@gnu.org> skribis:
> > The way I see it, service configuration should be oblivious to
> > whether it’s started as “forkexec”, systemd, or inetd.
has me in a bit of a bind in multiple ways.  For one, I don't see a
direct translation from MPD's configuration scheme to shepherd's.  For
another, the distinct semantics between forkexec and lazy loading cause
observable differences as in “What the fuck, I only ran mpc status, why
is the music now playing?” – this can be avoided if the user knows that
shepherd will be lazy-loading mpd and that it might as a result to
starting start playing on the first received command.

Moreover, I think the patch I added to make endpoint records
configurable from Guix could also serve to solve other bugs, e.g. SSH
only listening on IPv4 addresses, which would require us to be able to
specify whether to listen on IPv4, IPv6 or both through Guix.  Long
term, I think we should only keep the distinction between forkexec and
inetd/systemd for those services where it makes an observable
difference, like mpd.  For SSH, apart from bugs and perhaps people
using old shepherd, I don't think there'd be any reason to keep
forkexec beyond a certain point (in a future as distant as you would
want it to be).

Maxime also raised hygiene concerns that would be comparatively easy to
solve.

TL;DR: v2 [1/3] is good, [2/3 WIP] and [3/3 WIP] should be kept back
for now.

Cheers




  reply	other threads:[~2022-05-13 17:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 10:01 [bug#54986] [PATCH] gnu: mpd: Add support for socket activation Liliana Marie Prikler
2022-04-17 10:01 ` [bug#54986] [PATCH v2 1/3] " Liliana Marie Prikler
2022-04-17 21:06 ` [bug#54986] [PATCH] " Ludovic Courtès
2022-04-17 21:57   ` Liliana Marie Prikler
2022-04-18 21:05     ` Ludovic Courtès
2022-04-18 21:19       ` Liliana Marie Prikler
2022-04-27 20:56         ` Ludovic Courtès
2022-04-28 16:45           ` Liliana Marie Prikler
2022-04-23 14:25 ` [bug#54986] [PATCH v2 2/3 WIP] services: shepherd: Add support for socket activation endpoints Liliana Marie Prikler
2022-04-27 22:05   ` Ludovic Courtès
2022-04-23 14:25 ` [bug#54986] [PATCH v3 1/2] " Liliana Marie Prikler
2023-04-26  0:33   ` [bug#54986] [PATCH] gnu: mpd: Add support for socket activation Maxim Cournoyer
2023-04-26  4:28     ` Liliana Marie Prikler
2023-05-01 15:53       ` Maxim Cournoyer
2023-05-01 16:09         ` Liliana Marie Prikler
2023-05-03  3:17           ` Maxim Cournoyer
2023-05-03 13:27           ` Ludovic Courtès
2023-05-03 16:54             ` Liliana Marie Prikler
2023-05-10 15:14               ` Ludovic Courtès
2023-05-10 18:32                 ` Liliana Marie Prikler
2023-05-11 10:52                   ` Ludovic Courtès
2022-04-23 14:39 ` [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support " Liliana Marie Prikler
2022-04-23 17:31   ` Maxime Devos
2022-04-23 18:36     ` Liliana Marie Prikler
2022-04-23 17:35   ` Maxime Devos
2022-04-23 18:28     ` Liliana Marie Prikler
2022-04-27 22:08   ` Ludovic Courtès
2022-05-13 15:55     ` [bug#54986] [PATCH] gnu: mpd: Add support for " Ludovic Courtès
2022-05-13 17:00       ` Liliana Marie Prikler [this message]
2022-04-23 14:39 ` [bug#54986] [PATCH v3 2/2] services: mpd: Support " Liliana Marie Prikler
2022-10-23 11:38   ` Liliana Marie Prikler
2022-11-26 12:59     ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3bb074bff53a0503742b953762ac46de5f0b9cc.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=54986@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.