From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 54986@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#54986] [PATCH] gnu: mpd: Add support for socket activation.
Date: Fri, 13 May 2022 17:55:36 +0200 [thread overview]
Message-ID: <87ee0xfmvb.fsf_-_@gnu.org> (raw)
In-Reply-To: <87y1zqfabs.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 28 Apr 2022 00:08:55 +0200")
Hi Liliana,
What’s the status of this patch series? Would be nice to have it in!
Ludo’.
Ludovic Courtès <ludo@gnu.org> skribis:
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
>> * gnu/services/audio.scm (<mpd-configuration>)[shepherd-endpoints]: New field.
>> (mpd-shepherd-service): Use it.
>> * doc/guix.texi (Music Player Daemon): Document it.
>
> [...]
>
>> +++ b/gnu/services/audio.scm
>> @@ -78,6 +78,8 @@ (define-record-type* <mpd-configuration>
>> (default "6600"))
>> (address mpd-configuration-address
>> (default "any"))
>> + (shepherd-endpoints mpd-configuration-shepherd-endpoints
>> + (default '())) ; list of <shepherd-endpoint>
>
> The way I see it, service configuration should be oblivious to whether
> it’s started as “forkexec”, systemd, or inetd.
>
> There’s already an ‘address’ field above, so my suggestion would be to
> reuse it. This is what I did for example for the openssh service, and
> also for bitlbee and dicod here:
>
> https://issues.guix.gnu.org/54997#5
>
> WDYT?
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2022-05-13 16:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 10:01 [bug#54986] [PATCH] gnu: mpd: Add support for socket activation Liliana Marie Prikler
2022-04-17 10:01 ` [bug#54986] [PATCH v2 1/3] " Liliana Marie Prikler
2022-04-17 21:06 ` [bug#54986] [PATCH] " Ludovic Courtès
2022-04-17 21:57 ` Liliana Marie Prikler
2022-04-18 21:05 ` Ludovic Courtès
2022-04-18 21:19 ` Liliana Marie Prikler
2022-04-27 20:56 ` Ludovic Courtès
2022-04-28 16:45 ` Liliana Marie Prikler
2022-04-23 14:25 ` [bug#54986] [PATCH v2 2/3 WIP] services: shepherd: Add support for socket activation endpoints Liliana Marie Prikler
2022-04-27 22:05 ` Ludovic Courtès
2022-04-23 14:25 ` [bug#54986] [PATCH v3 1/2] " Liliana Marie Prikler
2023-04-26 0:33 ` [bug#54986] [PATCH] gnu: mpd: Add support for socket activation Maxim Cournoyer
2023-04-26 4:28 ` Liliana Marie Prikler
2023-05-01 15:53 ` Maxim Cournoyer
2023-05-01 16:09 ` Liliana Marie Prikler
2023-05-03 3:17 ` Maxim Cournoyer
2023-05-03 13:27 ` Ludovic Courtès
2023-05-03 16:54 ` Liliana Marie Prikler
2023-05-10 15:14 ` Ludovic Courtès
2023-05-10 18:32 ` Liliana Marie Prikler
2023-05-11 10:52 ` Ludovic Courtès
2022-04-23 14:39 ` [bug#54986] [PATCH v3 2/2] services: mpd: Support " Liliana Marie Prikler
2022-10-23 11:38 ` Liliana Marie Prikler
2022-11-26 12:59 ` Liliana Marie Prikler
2022-04-23 14:39 ` [bug#54986] [PATCH v2 3/3 WIP] " Liliana Marie Prikler
2022-04-23 17:31 ` Maxime Devos
2022-04-23 18:36 ` Liliana Marie Prikler
2022-04-23 17:35 ` Maxime Devos
2022-04-23 18:28 ` Liliana Marie Prikler
2022-04-27 22:08 ` Ludovic Courtès
2022-05-13 15:55 ` Ludovic Courtès [this message]
2022-05-13 17:00 ` [bug#54986] [PATCH] gnu: mpd: Add support for " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee0xfmvb.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54986@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.