[bug#35661] [PATCH] doc: Fix typo.

[bug#35661] [PATCH] doc: Fix typo.

[Diego Nicola Barbato]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

Hi Guix,

The documentation of 'shepherd-service' erroneously calls the
'requirement' field 'requirements'.  The attached patch fixes that.

I have also noticed that the 'auto-start?' field is not mentioned at
all.

Regards,

Diego


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-Fix-typo.patch --]
[-- Type: text/x-patch, Size: 916 bytes --]

From 635fa669c8d52afd2363c99bfa03b2315af29e74 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato@posteo.de>
Date: Thu, 9 May 2019 22:44:45 +0200
Subject: [PATCH] doc: Fix typo.

* doc/guix.texi (shepherd-service): 'requirement' instead of 'requirements'.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index df7208229c..f88fa827d4 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25279,7 +25279,7 @@ These are the names that may be passed to @command{herd start},
 shepherd, The GNU Shepherd Manual}).  @xref{Slots of services, the
 @code{provides} slot,, shepherd, The GNU Shepherd Manual}, for details.
 
-@item @code{requirements} (default: @code{'()})
+@item @code{requirement} (default: @code{'()})
 List of symbols denoting the Shepherd services this one depends on.
 
 @cindex one-shot services, for the Shepherd
-- 
2.21.0

bug#35661: [PATCH] doc: Fix typo.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]


> The documentation of 'shepherd-service' erroneously calls the
> 'requirement' field 'requirements'.  The attached patch fixes that.

Thanks! I added a copyright header for you and pushed the patch.

> I have also noticed that the 'auto-start?' field is not mentioned at
> all.

Could you submit a patch fixing this?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#35661] [PATCH] doc: Fix typo.

[Diego Nicola Barbato]

Arun Isaac <arunisaac@systemreboot.net> writes:

>> The documentation of 'shepherd-service' erroneously calls the
>> 'requirement' field 'requirements'.  The attached patch fixes that.
>
> Thanks! I added a copyright header for you and pushed the patch.

Thanks!  I was not aware that removing a single character would warrant
the addition of a copyright header.  I have made less trivial changes in
the past and I have never added a copyright line.  Should I do something
about that?

[bug#35661] [PATCH] doc: Fix typo.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]


> I was not aware that removing a single character would warrant the
> addition of a copyright header.

I am not aware of any policy about this in the Guix project. But, I have
seen people do it both ways -- both adding and not adding copyright
headers for trivial changes. So, I generally add copyright headers for
all changes no matter how trivial.

> I have made less trivial changes in the past and I have never added a
> copyright line.  Should I do something about that?

I think you can ignore those instances. Even I have made trivial changes
before and not added a copyright header.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]