all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30196@debbugs.gnu.org
Subject: [bug#30196] [PATCH 2/2] gnu: services: Add wesnothd service.
Date: Thu, 08 Feb 2018 17:42:38 +0530	[thread overview]
Message-ID: <cu7d11f8ytl.fsf@systemreboot.net> (raw)
In-Reply-To: <87372e6t6s.fsf@gnu.org>


>> * gnu/services/games.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>> * doc/guix.texi (Game Services): Document the service.
>
> LGTM, thanks!

Thanks, I'll push with the changes you mentioned.

> You’d get bonus points by writing a system test, but perhaps there’s not
> much that could easily be tested.  So, no big deal.

I might be able to write a simple test that checks if the server has
started successfully and is listening on port 15000. But, this seems too
trivial a test to me. Is it worth it? WDYT?

  reply	other threads:[~2018-02-08 12:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-21 18:33 [bug#30196] [PATCH 0/2] Add wesnothd service Arun Isaac
2018-01-21 18:37 ` [bug#30196] [PATCH 1/2] gnu: Add wesnoth-server Arun Isaac
2018-02-06 15:18   ` Ludovic Courtès
2018-01-22 12:11 ` [bug#30196] [PATCH 2/2] gnu: services: Add wesnothd service Arun Isaac
2018-02-06 15:20   ` Ludovic Courtès
2018-02-08 12:12     ` Arun Isaac [this message]
2018-02-08 21:57       ` Ludovic Courtès
2018-02-09  9:52       ` bug#30196: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cu7d11f8ytl.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=30196@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.