From: Arun Isaac <arunisaac@systemreboot.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34948@debbugs.gnu.org
Subject: [bug#34948] [PATCH 3/3] system: Add 'essential-services' field to <operating-system>.
Date: Tue, 26 Mar 2019 02:12:26 +0530 [thread overview]
Message-ID: <cu7bm1ywurx.fsf@systemreboot.net> (raw)
In-Reply-To: <20190322172719.11199-3-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
This neatly gets rid of all the #:container? arguments. That's very
nice! :-) I haven't actually built and tested these patches, but these
LGTM. Just one minor observation below.
> + (cons (service system-service-type
> + (let ((locale (operating-system-locale-directory os)))
> + (with-monad %store-monad
> + (return `(("locale" ,locale))))))
> + (append base (list %containerized-shepherd-service))))
Why not rewrite this using just a call to append, that is remove the
call to cons? Like so:
(append base
(list (service system-service-type
(let ((locale (operating-system-locale-directory os)))
(with-monad %store-monad
(return `(("locale" ,locale))))))
%containerized-shepherd-service))
Or perhaps, this can be done with cons* also.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-03-25 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:21 [bug#34948] [PATCH 0/3] Turn 'essential-services' into an <operating-system> field Ludovic Courtès
2019-03-22 17:27 ` [bug#34948] [PATCH 1/3] records: Allow thunked fields to refer to 'this-record' Ludovic Courtès
2019-03-22 17:27 ` [bug#34948] [PATCH 2/3] accounts: Add default value for the 'home-directory' field of <user-account> Ludovic Courtès
2019-03-22 17:27 ` [bug#34948] [PATCH 3/3] system: Add 'essential-services' field to <operating-system> Ludovic Courtès
2019-03-25 20:42 ` Arun Isaac [this message]
2019-03-25 23:02 ` bug#34948: " Ludovic Courtès
2019-03-26 6:58 ` [bug#34948] " Arun Isaac
2019-03-22 21:53 ` [bug#34948] [PATCH 1/3] records: Allow thunked fields to refer to 'this-record' Ricardo Wurmus
2019-03-23 15:18 ` Ludovic Courtès
2019-03-23 16:05 ` Ludovic Courtès
2019-03-30 10:37 ` Ludovic Courtès
2019-03-30 14:20 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cu7bm1ywurx.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=34948@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.