From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:35095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8WZ0-0003BJ-1k
	for guix-patches@gnu.org; Mon, 25 Mar 2019 16:51:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8WQw-000398-F9
	for guix-patches@gnu.org; Mon, 25 Mar 2019 16:43:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45179)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h8WQw-00038f-Bu
	for guix-patches@gnu.org; Mon, 25 Mar 2019 16:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8WQw-0001Xd-7y
	for guix-patches@gnu.org; Mon, 25 Mar 2019 16:43:02 -0400
Subject: [bug#34948] [PATCH 3/3] system: Add 'essential-services' field to
	<operating-system>.
Resent-Message-ID: <handler.34948.B34948.15535465595895@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <20190322172719.11199-3-ludo@gnu.org>
References: <20190322172719.11199-1-ludo@gnu.org>
	<20190322172719.11199-3-ludo@gnu.org>
Date: Tue, 26 Mar 2019 02:12:26 +0530
Message-ID: <cu7bm1ywurx.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 34948@debbugs.gnu.org

--=-=-=
Content-Type: text/plain


This neatly gets rid of all the #:container? arguments. That's very
nice! :-) I haven't actually built and tested these patches, but these
LGTM. Just one minor observation below.

> +  (cons (service system-service-type
> +                 (let ((locale (operating-system-locale-directory os)))
> +                   (with-monad %store-monad
> +                     (return `(("locale" ,locale))))))
> +        (append base (list %containerized-shepherd-service))))

Why not rewrite this using just a call to append, that is remove the
call to cons? Like so:

(append base
        (list (service system-service-type
                       (let ((locale (operating-system-locale-directory os)))
                         (with-monad %store-monad
                                     (return `(("locale" ,locale))))))
              %containerized-shepherd-service))

Or perhaps, this can be done with cons* also.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlyZPTMACgkQLiXui2GA
K7NvDAf+N6f/lfZ3ioBRXchVbm1YkrOphVaSrSWchEbtNXFofdkwPsh/7dkx0u1C
v8NFkx66iqSKb9ISUlpw7X4zr/O6VUPI7DBC+qSwsN67u8AmLdBa7n5JzMYRLjTD
qnp6Cbc7hdAsdW6qHDET6VIpuOuHTZ88vzPrDg5ifi5jC2dwsLz0+z8/hc+opaPe
Eq5rcy6nQy1WktWOWelTaMF37KDVdtYRtqiptOvErLRQdi2grQ5vjKUU3A7r6Nh1
UwF8NFU6xDuzge1UYsvUE9Fm0ti1DWb4XiekFQmIJRKzVERjVk6P4BkQp/Z3mGKp
znlvMazMrsNDYY96Sd/ToXHnfblkKQ==
=92YS
-----END PGP SIGNATURE-----
--=-=-=--