From: Arun Isaac <arunisaac@systemreboot.net>
To: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>,
31036@debbugs.gnu.org
Subject: [bug#31036] [PATCH] gnu: Add Emacs dumb-jump
Date: Tue, 03 Apr 2018 23:04:29 +0530 [thread overview]
Message-ID: <cu78ta42nyy.fsf@systemreboot.net> (raw)
In-Reply-To: <20180403023403.GA4430@sam>
Thank you for contributing to Guix! The following are some changes.
> +;; the version needs to have a v in it because of how the github releases are maintained.
> +(define-public emacs-dumb-jump
> +(package
> + (name "emacs-dumb-jump")
> + (version "v0.5.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/jacktasia/dumb-jump/archive/"
> + version ".tar.gz"))
We normally include the "v" in the source URI itself, not in the
version. So, you'd end up with the following uri.
(string-append "https://github.com/jacktasia/dumb-jump/archive/v" version ".tar.gz")
> + (synopsis
> + "Jump to definition for multiple languages without configuration")
> + (description
> + "Dumb Jump is an Emacs \"jump to definition\" package with support for
> +multiple programming languages that favors \"just working\" over speed or
> +accuracy. This means minimal -- and ideally zero -- configuration with
> +absolutely no stored indexes (TAGS) or persistent background processes. Dumb
Downcase TAGS to tags.
> +Jump performs best with The Silver Searcher `ag` or ripgrep `rg` installed.
Please put ag and rg within @command{} -- @command{ag} and @command{rg}.
This package appears to have tests. Could you add a check phase for
running them?
Also, the first line of the commit message should read
gnu: Add emacs-dumb-jump.
not
gnu: Add Emacs dumb-jump.
Could you send an updated patch?
Thanks!
next prev parent reply other threads:[~2018-04-03 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 2:34 [bug#31036] [PATCH] gnu: Add Emacs dumb-jump Sohom Bhattacharjee
2018-04-03 17:34 ` Arun Isaac [this message]
[not found] ` <29a411b7.AL4AAAOBQdEAAAAAAAAAAAO0oB8AAAACwQwAAAAAAAW9WABaw7s5@mailjet.com>
2018-04-09 15:00 ` Sohom Bhattacharjee
2018-04-09 16:12 ` Maxim Cournoyer
2018-04-11 2:50 ` Sohom Bhattacharjee
2018-04-11 5:18 ` Arun Isaac
[not found] ` <f25b8830.AMUAAARKSBwAAAAAAAAAAAO0oB8AAAACwQwAAAAAAAW9WABazZq-@mailjet.com>
2018-04-12 6:50 ` Sohom Bhattacharjee
2018-04-13 3:52 ` Maxim Cournoyer
2018-05-03 18:04 ` bug#31036: " Arun Isaac
2018-05-05 18:42 ` [bug#31036] " Oleg Pykhalov
2018-05-06 9:07 ` Arun Isaac
2018-05-07 16:33 ` Oleg Pykhalov
2018-04-14 16:57 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cu78ta42nyy.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=31036@debbugs.gnu.org \
--cc=soham.bhattacharjee15@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.