From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f3Ppp-0007HD-Qq
	for guix-patches@gnu.org; Tue, 03 Apr 2018 13:35:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f3Ppm-0001EM-MM
	for guix-patches@gnu.org; Tue, 03 Apr 2018 13:35:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57656)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f3Ppm-0001ED-ID
	for guix-patches@gnu.org; Tue, 03 Apr 2018 13:35:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f3Ppm-0003de-8Z
	for guix-patches@gnu.org; Tue, 03 Apr 2018 13:35:02 -0400
Subject: [bug#31036] [PATCH] gnu: Add Emacs dumb-jump
Resent-Message-ID: <handler.31036.B31036.152277688713961@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <20180403023403.GA4430@sam>
References: <20180403023403.GA4430@sam>
Date: Tue, 03 Apr 2018 23:04:29 +0530
Message-ID: <cu78ta42nyy.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Sohom Bhattacharjee <soham.bhattacharjee15@gmail.com>, 31036@debbugs.gnu.org


Thank you for contributing to Guix! The following are some changes.

> +;; the version needs to have a v in it because of how the github releases are maintained.
> +(define-public emacs-dumb-jump
> +(package
> +  (name "emacs-dumb-jump")
> +  (version "v0.5.2")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "https://github.com/jacktasia/dumb-jump/archive/"
> +             version ".tar.gz"))

We normally include the "v" in the source URI itself, not in the
version. So, you'd end up with the following uri.

(string-append "https://github.com/jacktasia/dumb-jump/archive/v" version ".tar.gz")

> +  (synopsis
> +    "Jump to definition for multiple languages without configuration")
> +  (description
> +    "Dumb Jump is an Emacs \"jump to definition\" package with support for
> +multiple programming languages that favors \"just working\" over speed or
> +accuracy.  This means minimal -- and ideally zero -- configuration with
> +absolutely no stored indexes (TAGS) or persistent background processes.  Dumb

Downcase TAGS to tags.

> +Jump performs best with The Silver Searcher `ag` or ripgrep `rg` installed.

Please put ag and rg within @command{} -- @command{ag} and @command{rg}.

This package appears to have tests. Could you add a check phase for
running them?

Also, the first line of the commit message should read

gnu: Add emacs-dumb-jump.

not

gnu: Add Emacs dumb-jump.

Could you send an updated patch?

Thanks!