[bug#65751] [PATCH 0/2] Update emacs-magit to 3.3.0-5.186414a.

[bug#65751] [PATCH 0/2] Update emacs-magit to 3.3.0-5.186414a.

[Maxim Cournoyer]

Using a recent commit allows benefiting from a change that would be useful for
adding 'Reviewed-by' tags to Git messages (see:
https://github.com/magit/magit/discussions/4998).

Maxim Cournoyer (2):
  gnu: emacs-transient: Update to 0.4.3-0.cc0fa80.
  gnu: emacs-magit: Update to 3.3.0-5.186414a.

 gnu/packages/emacs-xyz.scm | 78 ++++++++++++++++++++------------------
 1 file changed, 42 insertions(+), 36 deletions(-)


base-commit: bf231a591c874dd7af57923f0b513823d1e0d6d2
-- 
2.41.0

[bug#65751] [PATCH 1/2] gnu: emacs-transient: Update to 0.4.3-0.cc0fa80.

[Maxim Cournoyer]

* gnu/packages/emacs-xyz.scm (emacs-transient): Update to 0.4.3-0.cc0fa80.
---

 gnu/packages/emacs-xyz.scm | 70 ++++++++++++++++++++------------------
 1 file changed, 37 insertions(+), 33 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 802cf1ccaa..c3652c703c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30150,43 +30150,47 @@ (define-public emacs-elmacro
     (license license:gpl3+)))
 
 (define-public emacs-transient
-  (package
-    (name "emacs-transient")
-    (version "0.4.3")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/magit/transient")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "03qs1bj7dxgdppzcnhzmldpdam1h8kzd0ps2bk82slypm7d63nay"))))
-    (build-system emacs-build-system)
-    (arguments
-     `(#:tests? #f                      ;no test suite
-       #:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'build-info-manual
-                    (lambda _
-                      (invoke "make" "info")
-                      ;; Move the info file to lisp so that it gets
-                      ;; installed by the emacs-build-system.
-                      (rename-file "docs/transient.info"
-                                   "lisp/transient.info")))
-                  (add-after 'build-info-manual 'enter-lisp-directory
-                    (lambda _
-                      (chdir "lisp"))))))
-    (native-inputs (list texinfo))
-    (propagated-inputs (list emacs-compat))
-    (home-page "https://magit.vc/manual/transient")
-    (synopsis "Transient commands in Emacs")
-    (description
-     "Taking inspiration from prefix keys and prefix arguments
+  ;; Use this unreleased commit to support a recent Magit change needed to add
+  ;; Reviewed-by: tags for any contributor.
+  (let ((commit "cc0fa80530b02493f73b870032bfcdd1435286cd")
+        (revision "0"))
+    (package
+      (name "emacs-transient")
+      (version (git-version "0.4.3" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/magit/transient")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "10yaanpz3krh3f9vzyafg6n85yp8sk58gj9vrpsqg926x4m0w1p1"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:tests? #f                      ;no test suite
+         #:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'build-info-manual
+                      (lambda _
+                        (invoke "make" "info")
+                        ;; Move the info file to lisp so that it gets
+                        ;; installed by the emacs-build-system.
+                        (rename-file "docs/transient.info"
+                                     "lisp/transient.info")))
+                    (add-after 'build-info-manual 'enter-lisp-directory
+                      (lambda _
+                        (chdir "lisp"))))))
+      (native-inputs (list texinfo))
+      (propagated-inputs (list emacs-compat))
+      (home-page "https://magit.vc/manual/transient")
+      (synopsis "Transient commands in Emacs")
+      (description
+       "Taking inspiration from prefix keys and prefix arguments
 in Emacs, Transient implements a similar abstraction involving a prefix
 command, infix arguments and suffix commands.  We could call this abstraction
 a \"transient command\", but because it always involves at least two
 commands (a prefix and a suffix) we prefer to call it just a \"transient\".")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-forge
   (package

base-commit: bf231a591c874dd7af57923f0b513823d1e0d6d2
-- 
2.41.0

[bug#65751] [PATCH 2/2] gnu: emacs-magit: Update to 3.3.0-5.186414a.

[Maxim Cournoyer]

* gnu/packages/emacs-xyz.scm (emacs-magit): Update to 3.3.0-5.186414a.

---

 gnu/packages/emacs-xyz.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c3652c703c..e7a98a2ee4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1441,8 +1441,10 @@ (define-public emacs-libgit
       (license license:gpl2+))))
 
 (define-public emacs-magit
-  (let ((commit "a760dd107843a8fb632e647f6ba9ed34d7c2dd45")
-        (revision "4"))
+    ;; Use this unreleased commit to benefit from a recent change needed to
+    ;; add Reviewed-by: tags for any contributor in commit messages.
+  (let ((commit "186414ae418a07a46c413f05c68413a76256a05e")
+        (revision "5"))
     (package
       (name "emacs-magit")
       (version (git-version "3.3.0" revision commit))
@@ -1454,7 +1456,7 @@ (define-public emacs-magit
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0pqw171xi9vrlm0jkz53bhl18z2vnycn2bynb7lh6g5zgppkzdy0"))))
+          (base32 "0rhsbcjfjw0z3vy2ix30y4h55c0cx4lyvz6mbijwbbjryln71kpj"))))
       (build-system emacs-build-system)
       (arguments
        (list
-- 
2.41.0

[bug#65751] [PATCH 0/2] Update emacs-magit to 3.3.0-5.186414a.

[Andrew Tropin]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

On 2023-09-04 23:59, Maxim Cournoyer wrote:

> Using a recent commit allows benefiting from a change that would be useful for
> adding 'Reviewed-by' tags to Git messages (see:
> https://github.com/magit/magit/discussions/4998).
>
> Maxim Cournoyer (2):
>   gnu: emacs-transient: Update to 0.4.3-0.cc0fa80.
>   gnu: emacs-magit: Update to 3.3.0-5.186414a.
>
>  gnu/packages/emacs-xyz.scm | 78 ++++++++++++++++++++------------------
>  1 file changed, 42 insertions(+), 36 deletions(-)
>
>
> base-commit: bf231a591c874dd7af57923f0b513823d1e0d6d2

Patch series looks good to me.

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#65751: [PATCH 0/2] Update emacs-magit to 3.3.0-5.186414a.

[Maxim Cournoyer]

Hi,

Andrew Tropin <andrew@trop.in> writes:

> On 2023-09-04 23:59, Maxim Cournoyer wrote:
>
>> Using a recent commit allows benefiting from a change that would be useful for
>> adding 'Reviewed-by' tags to Git messages (see:
>> https://github.com/magit/magit/discussions/4998).
>>
>> Maxim Cournoyer (2):
>>   gnu: emacs-transient: Update to 0.4.3-0.cc0fa80.
>>   gnu: emacs-magit: Update to 3.3.0-5.186414a.
>>
>>  gnu/packages/emacs-xyz.scm | 78 ++++++++++++++++++++------------------
>>  1 file changed, 42 insertions(+), 36 deletions(-)
>>
>>
>> base-commit: bf231a591c874dd7af57923f0b513823d1e0d6d2
>
> Patch series looks good to me.

Installed, thanks for the review.

-- 
Thanks,
Maxim