From: Maxime Devos via Guix-patches <guix-patches@gnu.org>
To: 50627@debbugs.gnu.org, muradm <mail@muradm.net>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#50627] [PATCH v1] gnu: gtk: Move wayland-protocols to inputs.
Date: Thu, 6 Oct 2022 10:18:21 +0200 [thread overview]
Message-ID: <c7f1d197-084a-6def-890c-aa212886e9c9@student.kuleuven.be> (raw)
In-Reply-To: <20210916192331.29606-1-mail@muradm.net>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
Hi,
Removing a propagated input from gtk (by moving it to native-inputs)
sounds good, but I don't see the point of the inputs->native-inputs
changes. Now I see there is a revised patch at
<https://issues.guix.gnu.org/50627#8>
(albeit named v1 instead of v2).
Some comments on the new patch:
> diff --git a/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
> new file mode 100644
> index 0000000000..03196713bc
> --- /dev/null
> +++ b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
> @@ -0,0 +1,23 @@
> +diff --git a/configure b/configure
> +index edd41ad..cb36877 100755
> +--- a/configure
> ++++ b/configure
> [...]
'configure' is generated stuff, not source code, so now the result of
"guix build --source" is missing some source code (i.e., the revisions
to configure.ac).
Proposal: modify configure.ac instead, add autotools inputs and delete
'configure' such that Guix will automatically run autoreconf, see
<https://lists.gnu.org/archive/html/guix-devel/2022-04/msg00009.html>.
Greetings,
Maxime
[-- Attachment #2: Type: text/html, Size: 2387 bytes --]
prev parent reply other threads:[~2022-10-06 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 19:23 [bug#50627] [PATCH 0/2] Make wayland-protocols dependency native-input muradm
2021-09-16 19:26 ` [bug#50627] [PATCH 1/2] gnu: gtk: Move wayland-protocols to native-inputs muradm
2021-09-16 19:26 ` [bug#50627] [PATCH 2/2] gnu: Fix wayland-protocols dependency to be in native-inputs muradm
2021-09-16 19:57 ` [bug#50627] [PATCH 0/2] Make wayland-protocols dependency native-input Liliana Marie Prikler
2021-09-17 2:35 ` muradm
2021-09-17 7:46 ` Liliana Marie Prikler
2021-09-17 8:20 ` muradm
2021-09-17 13:01 ` Liliana Marie Prikler
2021-09-17 14:11 ` muradm
2021-09-17 17:01 ` Liliana Marie Prikler
2021-09-17 14:11 ` [bug#50627] [PATCH v1] gnu: gtk: Move wayland-protocols to inputs muradm
2022-10-06 8:18 ` Maxime Devos via Guix-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f1d197-084a-6def-890c-aa212886e9c9@student.kuleuven.be \
--to=guix-patches@gnu.org \
--cc=50627@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=mail@muradm.net \
--cc=maxime.devos@student.kuleuven.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.