From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qCtoBVOVPmP+NQAAbAwnHQ (envelope-from ) for ; Thu, 06 Oct 2022 10:44:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QKaNBFOVPmPsPAAAG6o9tA (envelope-from ) for ; Thu, 06 Oct 2022 10:44:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C143E17274 for ; Thu, 6 Oct 2022 10:44:02 +0200 (CEST) Received: from localhost ([::1]:39712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogMU5-0001uz-EJ for larch@yhetil.org; Thu, 06 Oct 2022 04:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogM5u-0003to-2S for guix-patches@gnu.org; Thu, 06 Oct 2022 04:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogM5t-0003f9-Q3 for guix-patches@gnu.org; Thu, 06 Oct 2022 04:19:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogM5t-00007a-KJ for guix-patches@gnu.org; Thu, 06 Oct 2022 04:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50627] [PATCH v1] gnu: gtk: Move wayland-protocols to inputs. References: <20210916192331.29606-1-mail@muradm.net> In-Reply-To: <20210916192331.29606-1-mail@muradm.net> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Oct 2022 08:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50627 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50627@debbugs.gnu.org, muradm , Liliana Marie Prikler Received: via spool by 50627-submit@debbugs.gnu.org id=B50627.1665044330449 (code B ref 50627); Thu, 06 Oct 2022 08:19:01 +0000 Received: (at 50627) by debbugs.gnu.org; 6 Oct 2022 08:18:50 +0000 Received: from localhost ([127.0.0.1]:58851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogM5h-000077-EK for submit@debbugs.gnu.org; Thu, 06 Oct 2022 04:18:49 -0400 Received: from icts-p-cavuit-2.kulnet.kuleuven.be ([134.58.240.131]:52586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogM5Y-00006f-KZ for 50627@debbugs.gnu.org; Thu, 06 Oct 2022 04:18:48 -0400 X-KULeuven-Envelope-From: maxime.devos@student.kuleuven.be X-KULeuven-Scanned: Found to be clean X-KULeuven-ID: 4E32920808.A7CF4 X-KULeuven-Information: Katholieke Universiteit Leuven Received: from icts-p-ceifnet-smtps-1.kuleuven.be (icts-p-ceifnet-smtps.service.icts.svcd [IPv6:2a02:2c40:0:51:131:242:ac11:29]) by icts-p-cavuit-2.kulnet.kuleuven.be (Postfix) with ESMTP id 4E32920808; Thu, 6 Oct 2022 10:18:30 +0200 (CEST) BCmilterd-Mark-Subject: no BCmilterd-Errors: BCmilterd-Report: X-CAV-Cluster: smtps Received: from [192.168.244.79] (unknown [188.188.26.214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by icts-p-ceifnet-smtps-1.kuleuven.be (Postfix) with ESMTPSA id AE0F2D4E3A53E; Thu, 6 Oct 2022 10:18:28 +0200 (CEST) Content-Type: multipart/alternative; boundary="------------iLl73saEj6Sg8U5wVCLvfife" Message-ID: Date: Thu, 6 Oct 2022 10:18:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US X-Kuleuven: This mail passed the K.U.Leuven mailcluster X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxime Devos via Guix-patches Reply-To: Maxime Devos Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665045842; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+PCObYC73aouEnKQgzcGKS+rEiB3mW37S1A5JGFVh+g=; b=VkhEiDE+9iG9ZxNRDiZSe+w5uV6tCjTnpkyjghFn++Dwjj1Id15cGGoDsbL5OkSXpVarTm V6X8nwdTI/Zn4KhL74FKon5QP/V/JxRq1TVbNsDSmGbzCl0+26IUX8hxkTYkq6jY6PaCll 0qB5fIIUAaryUjqMDmUByrqDhvWUXxdLTJ5QydQrDLBRPpBa5Faw+HUvwUpAfPIaA3201U D20OHAgvGdiNJyiiE77cA1mRGvYpsxt9NJ1TCltoQoPt1mL4InhanM7rm1nhHBH8+ejlb9 Ixrcs050Avx1czr6aqb1hORsY0v5ZA7mn3chK4TX9n3teBJXQwPj7pNEBonjaw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665045842; a=rsa-sha256; cv=none; b=QHeof8o/1KScJkvkFAkD6g7DdYy2kCDQMH+mGyfDBa0YPkKKhpbGMsuLlAGzqT30fblgdV aEzmo4UXSJdQGxnjSreMmUb2QAA1+Hq2/NmHTyUz5um0NT2CwRq4IeW/kRUo+LQDbwJUHz C8vGjHj3nuGpgWCZQWvKKCZrSDoud93M8Kuqjcy92liTipsjmyOci3oeM+5bwEx+oZzt0o anRDVJKCKVMXmgwc8CpTgwpLJsgL0hA3iXTBMUWzqNpA06WpIjDtk+wkmu2R9O5AV/ti4X lzdPsrtpb0pqYHlfM/sWi3NJ8EWZdPg/frKV6fGLzrTe596mKG0marHmf01N3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C143E17274 X-Spam-Score: -3.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: Zys4VZOKB5Tx This is a multi-part message in MIME format. --------------iLl73saEj6Sg8U5wVCLvfife Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Removing a propagated input from gtk (by moving it to native-inputs) sounds good, but I don't see the point of the inputs->native-inputs changes.  Now I see there is a revised patch at (albeit named v1 instead of v2). Some comments on the new patch: > diff --git a/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch > new file mode 100644 > index 0000000000..03196713bc > --- /dev/null > +++ b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch > @@ -0,0 +1,23 @@ > +diff --git a/configure b/configure > +index edd41ad..cb36877 100755 > +--- a/configure > ++++ b/configure > [...] 'configure' is generated stuff, not source code, so now the result of "guix build --source" is missing some source code (i.e., the revisions to configure.ac). Proposal: modify configure.ac instead, add autotools inputs and delete 'configure' such that Guix will automatically run autoreconf, see . Greetings, Maxime --------------iLl73saEj6Sg8U5wVCLvfife Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi,

Removing a propagated input from gtk (by moving it to native-inputs) sounds good, but I don't see the point of the inputs->native-inputs changes.  Now I see there is a revised patch at

<https://issues.guix.gnu.org/50627#8>

(albeit named v1 instead of v2).

Some comments on the new patch:

diff --git a/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
new file mode 100644
index 0000000000..03196713bc
--- /dev/null
+++ b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
@@ -0,0 +1,23 @@
+diff --git a/configure b/configure
+index edd41ad..cb36877 100755
+--- a/configure
++++ b/configure
[...]

'configure' is generated stuff, not source code, so now the result of "guix build --source" is missing some source code (i.e., the revisions to configure.ac).

Proposal: modify configure.ac instead, add autotools inputs and delete 'configure' such that Guix will automatically run autoreconf, see <https://lists.gnu.org/archive/html/guix-devel/2022-04/msg00009.html>.

Greetings,
Maxime

--------------iLl73saEj6Sg8U5wVCLvfife--