bug#52372: gash-utils & fzf conflict

bug#52372: gash-utils & fzf conflict

[Blake Shaw via Bug reports for GNU Guix]

Hello,

Gash-utils causes fzf to fail.

After installing gash-utils, attempting `bash5.0$ fzf` produces:
```
[Command failed: set -o pipefail; command find -L . -mindepth 1 \( -path '*/\.*' -o -fstype 'sysfs' -o -fstype 'devfs' -o -fstype 'devtmpfs' -o -fstype 'proc' \) -prune -o -type f -print -o -type l -print 2> /dev/null | cut -b3-]
```

Uninstalling gash-utils removes the problem.

Best,
Blake

bug#52372: gash-utils & fzf conflict

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Blake,

> Command failed: […] command find

This isn't ‘really’ a bug: fzf invokes whichever find(1) 
executable happens to be in $PATH at run time, and reasonably 
expects it to support the POSIX ‘-L’ option.

It also willfully tries to hide any useful error messages:

> 2> /dev/null

…maybe that's what makes Rust so safe?

gash-utils doesn't implement find -L, so failure is to be 
expected.  As you discovered the fix is as simple as uninstalling 
gash-utils, and possibly using it in a Guix environment if you 
really need it.

I don't think installing gash-utils globally into your main 
profile is a good idea!

Since find(1) is such a key requirement of fzf, it makes sense to 
treat it as a fixed input in this case and keep a reference to 
findutils' in a wrapper.

Done in commit 9bac41c2b8e7be5ab713402591ceeb32c635c214.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#52372: gash-utils & fzf conflict

[Maxime Devos]

Blake Shaw via Bug reports for GNU Guix schreef op wo 08-12-2021 om
18:23 [+0700]:
> 
> Hello,
> 
> Gash-utils causes fzf to fail.
> 
> After installing gash-utils, attempting `bash5.0$ fzf` produces:
> ```
> [Command failed: set -o pipefail; command find -L . -mindepth 1 \( -
> path '*/\.*' -o -fstype 'sysfs' -o -fstype 'devfs' -o -fstype
> 'devtmpfs' -o -fstype 'proc' \) -prune -o -type f -print -o -type l -
> print 2> /dev/null | cut -b3-]
> ```
> 
> Uninstalling gash-utils removes the problem.

Seems like 'coreutils' (or 'coreutils-minimal'?) should be added to the
wrap-program & inputs in the package definition of 'fzf' (untested),
and bin/fzf should be wrapped as well.

Or maybe it's not the fzf that is problematic, but the bash
completions.

Greetings,
Maxime.

bug#52372: gash-utils & fzf conflict

[Blake Shaw via Bug reports for GNU Guix]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

got it, thanks!

-- 
“In girum imus nocte et consumimur igni”

bug#52372: gash-utils & fzf conflict

[Timothy Sample]

Hi Blake and Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
writes:

> gash-utils doesn't implement find -L, so failure is to be expected.
> As you discovered the fix is as simple as uninstalling gash-utils, and
> possibly using it in a Guix environment if you really need it.
>
> I don't think installing gash-utils globally into your main profile is
> a good idea!

Definitely not!  Gash-Utils is very much pre-alpha software, and I don’t
really intend for those utilities to be useful beyond bootstrapping
their fully-featured GNU cousins.  Ideally there would be a
bootstrapping version of Gash-Utils that installs the utilities, and a
regular version that just has Scheme interfaces.  To date, it has felt a
little premature to bother with that.

However, if you find the Scheme interfaces from Gash-Utils useful, I’m
happy to make accommodations.  Right now, I think that Guilers either
write their own utilities like ‘find-files’ or they copy them out of
Guix’s ‘(guix build utils)’ module (I tend to do the latter).  It would
be nice if Gash-Utils could cover this use case and be a bit like
Python’s ‘shutil’, allowing a smoother transition from shell scripting
skills to Guile scripting skills.


-- Tim