all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
@ 2020-11-28  5:05 potentialuser54
  2020-11-28 15:27 ` Michael Rohleder
  0 siblings, 1 reply; 6+ messages in thread
From: potentialuser54 @ 2020-11-28  5:05 UTC (permalink / raw)
  To: 44916

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

After doing a fresh install of Guix system using the graphics install menu and picking the xfce option, I decided to substitute xfce's "Applications" menu with the "Whisker" menu.

Thus, I used command "guix install xfce4-whiskermenu-plugin" to install the package. After a system reboot, I opened the menu for adding items to the xfce panel. However, the option "Whisker Menu" isn't there.

I asked this problem on irc and irc user "mroh" told me that this plugin looks broken and they will try to fix it. They also asked me to make a bug report:
> mroh | PotentailUser-53: that plugin does indeed looks broken: ~/.guix-profile/bin/xfce4-popup-whiskermenu: line 47: /gnu/store/clmv25gbfjrajvh8bsnhfj3w86kry004-xfce4-whiskermenu-plugin-2.4.6/bin/xfce4-panel: No such file or directory

Regards.

[-- Attachment #2: Type: text/html, Size: 1078 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
  2020-11-28  5:05 bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin potentialuser54
@ 2020-11-28 15:27 ` Michael Rohleder
  2020-12-03 16:24   ` Kei Kebreau
  2020-12-06  5:11   ` Kei Kebreau
  0 siblings, 2 replies; 6+ messages in thread
From: Michael Rohleder @ 2020-11-28 15:27 UTC (permalink / raw)
  To: 44916


[-- Attachment #1.1: Type: text/plain, Size: 903 bytes --]

Thank you for reporting!

potentialuser54@postpro.net writes:
> After doing a fresh install of Guix system using the graphics install menu and picking the xfce option, I decided to substitute xfce's "Applications" menu with the "Whisker" menu.
>
> Thus, I used command "guix install xfce4-whiskermenu-plugin" to
> install the package. After a system reboot, I opened the menu for
> adding items to the xfce panel. However, the option "Whisker Menu"
> isn't there.
>
> I asked this problem on irc and irc user "mroh" told me that this plugin looks broken and they will try to fix it. They also asked me to make a bug report:
>> mroh | PotentailUser-53: that plugin does indeed looks broken:
> ~/.guix-profile/bin/xfce4-popup-whiskermenu: line 47:
> /gnu/store/clmv25gbfjrajvh8bsnhfj3w86kry004-xfce4-whiskermenu-plugin-2.4.6/bin/xfce4-panel:
> No such file or directory

Here is a first try to fix this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-xfce4-whiskermenu-plugin-Fix-installed-shell-scr.patch --]
[-- Type: text/x-patch, Size: 1455 bytes --]

>From c0157162c35dea28fd4f65c0b8bc87425358e7db Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sat, 28 Nov 2020 16:10:15 +0100
Subject: [PATCH] gnu: xfce4-whiskermenu-plugin: Fix installed shell script.

* gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): Fix installed shell script.
[arguments]: Add phase fix-shell-script to substitute path to xfce4-panel.
---
 gnu/packages/xfce.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fbe06a1c76..1e5ece0489 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -535,7 +535,15 @@ keys for controlling the audio volume.")
        ("gtk+" ,gtk+)
        ("libxfce4ui" ,libxfce4ui)))
     (arguments
-      `(#:tests? #f)) ; no tests
+     `(#:tests? #f                      ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-shell-script
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* (string-append "panel-plugin/xfce4-popup-whiskermenu.in")
+               (("@CMAKE_INSTALL_FULL_BINDIR@")
+                (string-append (assoc-ref inputs "xfce4-panel") "/bin")))
+             #t)))))
     (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin")
     (synopsis "Application menu panel plugin for Xfce")
     (description
-- 
2.29.2


[-- Attachment #1.3: Type: text/plain, Size: 174 bytes --]


Now, the shell script (path to xfce4-panel in the last line) looks fine,
but it still doesn't popup/display anything ;(

-- 
apples  have  meant  trouble  since  eden

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
  2020-11-28 15:27 ` Michael Rohleder
@ 2020-12-03 16:24   ` Kei Kebreau
  2020-12-06  5:11   ` Kei Kebreau
  1 sibling, 0 replies; 6+ messages in thread
From: Kei Kebreau @ 2020-12-03 16:24 UTC (permalink / raw)
  To: Michael Rohleder; +Cc: 44916

[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]

Hello all!

Michael Rohleder <mike@rohleder.de> writes:

> Thank you for reporting!
>
> potentialuser54@postpro.net writes:
>> After doing a fresh install of Guix system using the graphics
>> install menu and picking the xfce option, I decided to substitute
>> xfce's "Applications" menu with the "Whisker" menu.
>>
>> Thus, I used command "guix install xfce4-whiskermenu-plugin" to
>> install the package. After a system reboot, I opened the menu for
>> adding items to the xfce panel. However, the option "Whisker Menu"
>> isn't there.
>>
>> I asked this problem on irc and irc user "mroh" told me that this
>> plugin looks broken and they will try to fix it. They also asked me
>> to make a bug report:
>>> mroh | PotentailUser-53: that plugin does indeed looks broken:
>> ~/.guix-profile/bin/xfce4-popup-whiskermenu: line 47:
>> /gnu/store/clmv25gbfjrajvh8bsnhfj3w86kry004-xfce4-whiskermenu-plugin-2.4.6/bin/xfce4-panel:
>> No such file or directory
>
> Here is a first try to fix this:
>
>>>From c0157162c35dea28fd4f65c0b8bc87425358e7db Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Sat, 28 Nov 2020 16:10:15 +0100
> Subject: [PATCH] gnu: xfce4-whiskermenu-plugin: Fix installed shell script.
>
> * gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): Fix installed shell script.
> [arguments]: Add phase fix-shell-script to substitute path to xfce4-panel.
>

-- cut --

>
> Now, the shell script (path to xfce4-panel in the last line) looks fine,
> but it still doesn't popup/display anything ;(

The above patch partially fixes the script.  The path to the gettext binary
must be patched as well since gettext is used for printing the help
menu.

Aside from that, it seems like Xfce, when installed as a system-wide
desktop environment, does not look in the user's Guix profile for
plugins.  Panel modules are located by Xfce in the directories listed in
the X_XFCE4_LIB_DIRS environment variable.  For my Xfce configuration,
X_XFCE4_LIB_DIRS contains only /run/current-system/profile/lib/xfce4.

To work around this issue on your own machine for the time being, you
can add the desired Xfce plugins to the list of packages in your Guix
operating system configuration.  In the long-term, it will be worth
determining the best way to add the proper directories from the user's
Guix profile to the list of directories in X_XFCE4_LIB_DIRS.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
  2020-11-28 15:27 ` Michael Rohleder
  2020-12-03 16:24   ` Kei Kebreau
@ 2020-12-06  5:11   ` Kei Kebreau
  2020-12-06  5:29     ` potentialuser54
  1 sibling, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2020-12-06  5:11 UTC (permalink / raw)
  To: Michael Rohleder; +Cc: potentialuser54, 44916

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hello again!

If you are able, please take a look at patch #45062 linked below.  I've
slightly modified Michael's patch and added one of my own to take a shot
at solving this issue.  If it passes review (or no one says anything for
a while), these changes will be applied to Guix proper.

The patch is here: https://issues.guix.gnu.org/45062

Thanks,
Kei

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
  2020-12-06  5:11   ` Kei Kebreau
@ 2020-12-06  5:29     ` potentialuser54
  2023-08-25 10:20       ` 宋文武 via Bug reports for GNU Guix
  0 siblings, 1 reply; 6+ messages in thread
From: potentialuser54 @ 2020-12-06  5:29 UTC (permalink / raw)
  To: Kei Kebreau, Michael Rohleder; +Cc: 44916

Hello Kei and Michael,

Thank you for your work. I'm sorry that I lack technical expertise to comment on the patch, nor am I able to test it. I'm also not sure about if I should send this email or not because I could not provide any insights into this issue. Please inform me if you find this email annoying. 
Again, thank you for your work!

Regards.

On Sun, Dec 6, 2020, at 00:11, Kei Kebreau wrote:
> Hello again!
> 
> If you are able, please take a look at patch #45062 linked below.  I've
> slightly modified Michael's patch and added one of my own to take a shot
> at solving this issue.  If it passes review (or no one says anything for
> a while), these changes will be applied to Guix proper.
> 
> The patch is here: https://issues.guix.gnu.org/45062
> 
> Thanks,
> Kei
> 
> Attachments:
> * signature.asc




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin.
  2020-12-06  5:29     ` potentialuser54
@ 2023-08-25 10:20       ` 宋文武 via Bug reports for GNU Guix
  0 siblings, 0 replies; 6+ messages in thread
From: 宋文武 via Bug reports for GNU Guix @ 2023-08-25 10:20 UTC (permalink / raw)
  To: potentialuser54; +Cc: Kei Kebreau, 44916-done, Michael Rohleder

potentialuser54@postpro.net writes:

> Hello Kei and Michael,
>
> Thank you for your work. I'm sorry that I lack technical expertise to
> comment on the patch, nor am I able to test it. I'm also not sure
> about if I should send this email or not because I could not provide
> any insights into this issue. Please inform me if you find this email
> annoying.
> Again, thank you for your work!
>
> Regards.
>
> On Sun, Dec 6, 2020, at 00:11, Kei Kebreau wrote:
>> Hello again!
>> 
>> If you are able, please take a look at patch #45062 linked below.  I've
>> slightly modified Michael's patch and added one of my own to take a shot
>> at solving this issue.  If it passes review (or no one says anything for
>> a while), these changes will be applied to Guix proper.
>> 
>> The patch is here: https://issues.guix.gnu.org/45062
>> 
>> Thanks,
>> Kei
>> 
>> Attachments:
>> * signature.asc


Hello, I believe this issue had been fixed (since #45062), closing.

If not feel free to contact me, thanks!




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-08-25 10:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-28  5:05 bug#44916: No option to add whisker menu to xfce panel after installing package xfce4-whiskermenu-plugin potentialuser54
2020-11-28 15:27 ` Michael Rohleder
2020-12-03 16:24   ` Kei Kebreau
2020-12-06  5:11   ` Kei Kebreau
2020-12-06  5:29     ` potentialuser54
2023-08-25 10:20       ` 宋文武 via Bug reports for GNU Guix

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.