From: Vasile Dumitrascu <va511e@yahoo.com>
To: Marius Bakke <mbakke@fastmail.com>,
31954@debbugs.gnu.org, chewzerita@posteo.net
Subject: [bug#31954] [PATCH] gnu: Add emacs-org-brain.
Date: Wed, 04 Jul 2018 16:30:00 +0000 [thread overview]
Message-ID: <c02ece6e-2289-d9ca-09cc-09b17656aa2b@yahoo.com> (raw)
In-Reply-To: <87a7riek00.fsf@fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
Hi
@Marius: Please find attached an updated patch with the requested
changes. Do let me know if anything else is to be adjusted.
@Charlie: I am glad you find it useful. You are welcome!
Thank you,
Vasile
Marius Bakke:
> Vasile Dumitrascu <va511e@yahoo.com> writes:
>
>> * gnu/packages/emacs.scm (emacs-org-brain): New variable.
>
> Thanks for this patch! Overall it LGTM, but it does not apply to my git
> checkout, so here are some nitpicks that I'd normally fix myself:
>
> [...]
>
>> +(define-public emacs-org-brain
>> + (let ((version "20180522") ; no proper tag, use date of commit
>
> 'org-brain.el' has "Version: 0.5" in the source header. Perhaps we
> should use that instead?
>
> [...]
>
>> + (description "@code{emacs-org-brain} implements a variant of concept
>> +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of
>> +software called The Brain.")
>
> Make sure to use double spaces in descriptions (guix lint should complain
> about this). We also should not refer to nonfree software, can you try
> to expand on this description without mentioning the inspiration?
>
> The commentary inside 'org-brain.el' contains a pretty good description.
>
> Can you send an updated patch please? Thanks in advance!
>
[-- Attachment #2: 0001-gnu-Add-emacs-org-brain.patch --]
[-- Type: text/x-patch, Size: 1886 bytes --]
From 097ea36392360028cec20d2e8908755c926dcbcb Mon Sep 17 00:00:00 2001
From: Vasile Dumitrascu <va511e@yahoo.com>
Date: Wed, 4 Jul 2018 18:24:50 +0200
Subject: [PATCH] gnu: Add emacs-org-brain.
* gnu/packges/emacs.scm (emacs-org-brain): New variable.
---
gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 467791e21..712dd1363 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11290,3 +11290,29 @@ To use, add @code{allow-emacs-pinentry} to @code{~/.gnupg/gpg-agent.conf},
reload the configuration with @code{gpgconf --reload gpg-agent}, and start the
server with @code{M-x pinentry-start}.")
(license license:gpl3+))))
+
+(define-public emacs-org-brain
+ (package
+ (name "emacs-org-brain")
+ (version "0.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Kungsgeten/org-brain.git")
+ (commit "3faf9303af3f2356e3444e69c22dc6c5774047d1")))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1ad681zk6kckw2zbk0r4iaj4bw8cfqrbd1s3gdwgdjlzq81q9mmj"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/Kungsgeten/org-brain")
+ (synopsis "Org-mode wiki and concept-mapping for Emacs")
+ (description "@code{emacs-org-brain} implements a variant of concept
+mapping in Emacs, using @code{org-mode}. An org-brain is a network of
+org-mode entries, where each entry is a file or a headline, and you can get a
+visual overview of the relationships between the entries: parents, children,
+siblings and friends. This visual overview can also be used to browse your
+entries. You can think of entries as nodes in a mind map, or pages in a
+wiki.")
+ (license license:expat)))
--
2.18.0
next prev parent reply other threads:[~2018-07-04 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 9:29 [bug#31954] [PATCH] gnu: Add emacs-org-brain Vasile Dumitrascu
2018-06-24 12:30 ` Charlie Ritter
2018-06-25 19:36 ` Marius Bakke
2018-07-04 16:30 ` Vasile Dumitrascu [this message]
2018-07-07 15:51 ` bug#31954: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02ece6e-2289-d9ca-09cc-09b17656aa2b@yahoo.com \
--to=va511e@yahoo.com \
--cc=31954@debbugs.gnu.org \
--cc=chewzerita@posteo.net \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.