all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
@ 2022-01-01 13:08 路辉
  2022-01-02  3:58 ` Leo Famulari
  0 siblings, 1 reply; 4+ messages in thread
From: 路辉 @ 2022-01-01 13:08 UTC (permalink / raw)
  To: 52932

* gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g".
---
 gnu/packages/xorg.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index b09d95f770..fa747ebac4 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2021 Matthew James Kraai <kraai@ftbfs.org>
 ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
 ;;; Copyright © 2021 qblade <qblade@protonmail.com>
+;;; Copyright © 2021 Lu Hui <luhux76@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6446,7 +6447,8 @@ (define-public uim
        (list "--with-anthy-utf8"
              (string-append "--with-lispdir=" %output "/share/emacs")
              ;; Set proper runpath
-             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib"))
+             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib")
+             "CFLAGS=-O2 -g -fcommon")
        #:phases
        (modify-phases %standard-phases
          ;; Set path of uim-el-agent and uim-el-helper-agent executables
-- 
2.34.0




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
  2022-01-01 13:08 [bug#52932] [PATCH] gnu: uim: Build with '-O2' 路辉
@ 2022-01-02  3:58 ` Leo Famulari
  2022-01-02 14:19   ` 路辉
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2022-01-02  3:58 UTC (permalink / raw)
  To: 路辉; +Cc: 52932

On Sat, Jan 01, 2022 at 01:08:13PM +0000, 路辉 wrote:
> * gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g".

Thanks! I see this fixes the build.

> +             "CFLAGS=-O2 -g -fcommon")

Did you mean to use '-fcommon' too? It's not in the commit message.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
  2022-01-02  3:58 ` Leo Famulari
@ 2022-01-02 14:19   ` 路辉
  2022-01-02 17:43     ` bug#52932: " Leo Famulari
  0 siblings, 1 reply; 4+ messages in thread
From: 路辉 @ 2022-01-02 14:19 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 52932

[-- Attachment #1: Type: text/plain, Size: 33 bytes --]

sorry, I'm careless.

New patch v

[-- Attachment #2: 0001-gnu-uim-Build-with-O2-g-fcommon.patch --]
[-- Type: text/x-patch, Size: 1292 bytes --]

From 7cf15ce69ac9a46a8d0d05891d84c17c59ba73c6 Mon Sep 17 00:00:00 2001
From: Lu Hui <luhux76@gmail.com>
Date: Sat, 1 Jan 2022 15:53:22 +0800
Subject: [PATCH] gnu: uim: Build with '-O2 -g -fcommon'.

* gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g -fcommon".
---
 gnu/packages/xorg.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index b09d95f770..fa747ebac4 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2021 Matthew James Kraai <kraai@ftbfs.org>
 ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
 ;;; Copyright © 2021 qblade <qblade@protonmail.com>
+;;; Copyright © 2021 Lu Hui <luhux76@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6446,7 +6447,8 @@ (define-public uim
        (list "--with-anthy-utf8"
              (string-append "--with-lispdir=" %output "/share/emacs")
              ;; Set proper runpath
-             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib"))
+             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib")
+             "CFLAGS=-O2 -g -fcommon")
        #:phases
        (modify-phases %standard-phases
          ;; Set path of uim-el-agent and uim-el-helper-agent executables
-- 
2.34.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#52932: [PATCH] gnu: uim: Build with '-O2'.
  2022-01-02 14:19   ` 路辉
@ 2022-01-02 17:43     ` Leo Famulari
  0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2022-01-02 17:43 UTC (permalink / raw)
  To: 路辉; +Cc: 52932-done

On Sun, Jan 02, 2022 at 10:19:07PM +0800, 路辉 wrote:
> New patch v

> From 7cf15ce69ac9a46a8d0d05891d84c17c59ba73c6 Mon Sep 17 00:00:00 2001
> From: Lu Hui <luhux76@gmail.com>
> Date: Sat, 1 Jan 2022 15:53:22 +0800
> Subject: [PATCH] gnu: uim: Build with '-O2 -g -fcommon'.
> 
> * gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g -fcommon".

Thanks! Pushed as b2ed92ec58ea122e96b2f2b00f43af254b305c75




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-02 17:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-01 13:08 [bug#52932] [PATCH] gnu: uim: Build with '-O2' 路辉
2022-01-02  3:58 ` Leo Famulari
2022-01-02 14:19   ` 路辉
2022-01-02 17:43     ` bug#52932: " Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.