bug#63151: sound-juicer configure fails

bug#63151: sound-juicer configure fails

[Jack Hill]

Hi Guix,

sound-juicer fails to build in the configure phase. Exerpt:

```
Dependency iso-codes found: YES 4.5.0 (cached)
Run-time dependency libdiscid found: YES 0.6.2
Program gst-inspect-1.0 found: YES (/gnu/store/mz98ydpwa7hn5ky0q3g0xf66ps2ycfm2-gstreamer-1.22.2/bin/gst-inspect-1.0)
Configuring config.h using configuration
Program msgfmt found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/msgfmt)
Program msginit found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/msginit)
Program msgmerge found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/msgmerge)
Program xgettext found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/xgettext)
Program itstool found: YES (/gnu/store/r5mfs8m3ahvlivm7ccr5dh697g9lf59m-itstool-2.0.7/bin/itstool)
Program msgmerge found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/msgmerge)
Program msgfmt found: YES (/gnu/store/5d0fgnmh63yx98s1kfp57rc2x05xqk1d-gettext-minimal-0.21/bin/msgfmt)
Configuring org.gnome.SoundJuicer.desktop.in using configuration

../sound-juicer-3.38.0/data/meson.build:2:5: ERROR: Function does not take positional arguments.

A full log can be found at /tmp/guix-build-sound-juicer-3.38.0.drv-0/build/meson-logs/meson-log.txt
error: in phase 'configure': uncaught exception:
%exception #<&invoke-error program: "meson" arguments: ("setup" "--prefix=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0/lib" "/tmp/guix-build-sound-juicer-3.38.0.drv-0/sound-juicer-3.38.0") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `configure' failed after 2.0 seconds
command "meson" "setup" "--prefix=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/22j71a9rwi04dfd4f9i5ssg3jjl7zm4j-sound-juicer-3.38.0/lib" "/tmp/guix-build-sound-juicer-3.38.0.drv-0/sound-juicer-3.38.0" failed with status 1
```

Best,
Jack

bug#63151: sound-juicer configure fails

[Luis Felipe via Bug reports for GNU Guix]

[-- Attachment #1.1.1: Type: text/plain, Size: 138 bytes --]

Hi,

just to mention that this is still the case on guix 0aab248.

-- 
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2881 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

bug#63151: [PATCH] gnu: sound-juicer: Update to 3.40.0.

[iyzsong--- via Bug reports for GNU Guix]

From: 宋文武 <iyzsong@member.fsf.org>

* gnu/packages/gnome.scm (sound-juicer): Update to 3.40.0.
[arguments]<phases>: Adjust 'disable-gtk-update-icon-cache'.
Add 'wrap-program' for GST_PLUGIN_SYSTEM_PATH.
---
 gnu/packages/gnome.scm | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4a2e867476..8d8d091407 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11430,7 +11430,7 @@ (define-public passwordsafe
 (define-public sound-juicer
   (package
     (name "sound-juicer")
-    (version "3.38.0")
+    (version "3.40.0")
     (source
      (origin
        (method url-fetch)
@@ -11439,15 +11439,25 @@ (define-public sound-juicer
                            name "-" version ".tar.xz"))
        (sha256
         (base32
-         "08d5d81rz9sj3m5paw8fwbgxmhlbr7bcjdzpmzj832qvg8smydxf"))))
+         "1rhxmvx2mr22zd5p0azc0svi0mbnzcjnh3sasv3b9gli8ds85s1f"))))
     (build-system meson-build-system)
     (arguments
      (list
       #:glib-or-gtk? #t
-      #:phases #~(modify-phases %standard-phases
-                   (add-after 'unpack 'disable-gtk-update-icon-cache
-                     (lambda _
-                       (setenv "DESTDIR" "/"))))))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'disable-gtk-update-icon-cache
+            (lambda _
+              (substitute* "meson.build"
+                (("gtk_update_icon_cache: true")
+                 "gtk_update_icon_cache: false"))))
+          (add-after 'install 'wrap-program
+            (lambda _
+              (let ((prog (string-append #$output "/bin/sound-juicer"))
+                    (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                (wrap-program prog
+                  `("GST_PLUGIN_SYSTEM_PATH"
+                    ":" prefix (,gst-plugin-path)))))))))
     (native-inputs
      (list desktop-file-utils
            gettext-minimal

base-commit: 4e531e55dcdc99c83bcfe3eec67c3fd95c7b6ca7
-- 
2.41.0

bug#63151: [PATCH] gnu: sound-juicer: Update to 3.40.0.

[Maxim Cournoyer]

Hi,

iyzsong@envs.net writes:

> From: 宋文武 <iyzsong@member.fsf.org>
>
> * gnu/packages/gnome.scm (sound-juicer): Update to 3.40.0.
> [arguments]<phases>: Adjust 'disable-gtk-update-icon-cache'.
> Add 'wrap-program' for GST_PLUGIN_SYSTEM_PATH.

Installed, thank you!

Related: it doesn't find my CD drive, although I have two DVD drives
in there.  Is there something missing at the udev level in Guix System
for that to work?

-- 
Thanks,
Maxim

bug#63151: [PATCH] gnu: sound-juicer: Update to 3.40.0.

[宋文武 via Bug reports for GNU Guix]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi,
>
> iyzsong@envs.net writes:
>
>> From: 宋文武 <iyzsong@member.fsf.org>
>>
>> * gnu/packages/gnome.scm (sound-juicer): Update to 3.40.0.
>> [arguments]<phases>: Adjust 'disable-gtk-update-icon-cache'.
>> Add 'wrap-program' for GST_PLUGIN_SYSTEM_PATH.
>
> Installed, thank you!
>
> Related: it doesn't find my CD drive, although I have two DVD drives
> in there.  Is there something missing at the udev level in Guix System
> for that to work?

Without CD drivers I haven't test it, I guess the current user need
permissions for '/dev/sr*'.


Thank you handle the commits (also dbus-cxx ones)!

bug#65676: [PATCH] gnu: sound-juicer: Update to 3.40.0.

[宋文武 via Guix-patches via]

Pushed now, closing.