[bug#38951] gnu: Add libgovirt.

[bug#38951] gnu: Add libgovirt.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Hello Guix!

Please find the attached patch to add libgovirt.

Thank you!

Regards,
RG.

[-- Attachment #2: libgovirt.patch --]
[-- Type: application/octet-stream, Size: 1775 bytes --]

From 4b7c4d2efd25e0a338ff9670bf6fabaa8d8dab7c Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 5 Jan 2020 13:50:10 -0500
Subject: [PATCH] gnu: Add libgovirt.

* gnu/packages/gnome.scm (libgovirt): New variable.
---
 gnu/packages/gnome.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4413690e59..b0bd46f2da 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -247,6 +247,34 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))  
 
+(define-public libgovirt
+  (package
+   (name "libgovirt")
+   (version "0.3.6")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "19pb71pag3vsi83kbv8h08kimwym4hpw36kjl6a5ik5nk50mc8sg"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:tests? #f)) ; FIX-ME: Add test-suite.
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gtk+:bin" ,gtk+ "bin")
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("gobject-introspection" ,gobject-introspection)
+      ("librest" ,rest)))
+   (synopsis "GoVirt Library")
+   (description "GoVirt is a GObject wrapper for the oVirt REST API.")
+   (home-page "https://gitlab.gnome.org/GNOME/libgovirt")
+   (license license:gpl2+)))
+
 (define-public gnome-weather
   (package
    (name "gnome-weather")
-- 
2.24.1

bug#38951: gnu: Add libgovirt.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hi Raghav,

I've found the reason for the test failure by using this patch:

--- libgovirt-0.3.6/tests/mock-httpd.c.orig	2020-01-13 16:54:08.578009738 +0100
+++ libgovirt-0.3.6/tests/mock-httpd.c	2020-01-13 16:54:58.442238829 +0100
@@ -114,6 +114,9 @@
 		cert = g_tls_certificate_new_from_files (abs_srcdir "/https-cert/server-cert.pem",
 							 abs_srcdir "/https-cert/server-key.pem",
 							 &error);
+		if (error != NULL) {
+			fprintf(stderr, "ERROR: %s\n", error->message);
+		}
 		g_assert (error == NULL);
 		server = soup_server_new (SOUP_SERVER_SERVER_HEADER, "simple-soup-httpd ",
 					  SOUP_SERVER_TLS_CERTIFICATE, cert,

Then I fixed the test failure by adding glib-networking (which is a GIO plugin).

I suspect that the tests won't work reliably because of the networking
involved (even when local)--but let's cross that bridge when we come to it.

Committed to guix master as commit 3f1ed953e8a596dc3a4924758a931b8a774bde5f.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]