all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Martin Becze <mjbecze@riseup.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 37444@debbugs.gnu.org
Subject: [bug#37444] [PATCH] added aerc, a simple email client and its dependcies
Date: Tue, 01 Oct 2019 14:34:30 -0700	[thread overview]
Message-ID: <a4c7b0d6ed94267bb60103a78b71b02c@riseup.net> (raw)
In-Reply-To: <87blv7pfdi.fsf@gnu.org>

On 2019-09-26 09:37, Ludovic Courtès wrote:
> Hi Martin,
> 
> Martin Becze <mjbecze@riseup.net> skribis:
> 
>> On 2019-09-18 09:01, Ricardo Wurmus wrote:
>>> Hi Martin,
>>>
>>>> This adds aerc, which is a terminal based email client written in go.
>>>
>>> Thank you for your patch!
>>>
>>> Could you please separate the independent changes into separate commits
>>> and add commit summaries?  For example, the update of
>>> go-github-com-mitchellh-go-homedir should be done separately.
>>>
>>> Please also explain why “inputs” had to be changed to
>>> “propagated-inputs” in some packages, and mention these kind of changes
>>> in the commit summary.
>>>
>>> Thanks!
>>
>> just bumping, updated patch has been made and split into commits now.
>> https://issues.guix.gnu.org/issue/37444 let me know if that is ok
> 
> Like Ricardo mentioned, it would be great if patch #1 were split into
> several commits, one per new package.  That’s how we usually do it.
> 
> I saw your commit logs provide explanations.  However, they are all on
> the “subject line” of the commit log.  Could you take a look at
> <https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>
> regarding the format of commit logs, or run, say, “git log
> gnu/packages/golang.scm” to view examples?
> 
> I could do these changes on your behalf, but I’d rather let you do it to
> make sure I don’t mess up or misrepresent what you did!
> 
> Thanks,
> Ludo’.

ohhh i think i finally figured it out. (but not how to use
add-change-log-entry, it looks like ppl are using that to generate the
messages somehow?) anyways, v4 incoming!

  parent reply	other threads:[~2019-10-01 21:35 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  8:23 [bug#37444] [PATCH] added aerc, a simple email client and its dependcies Martin Becze
2019-09-18  9:01 ` Ricardo Wurmus
2019-09-18  9:20   ` Martin Becze
2019-09-18  9:29   ` Martin Becze
2019-09-18  9:42     ` Björn Höfling
2019-09-18  9:48     ` Tobias Geerinckx-Rice via Guix-patches via
2019-09-22  8:55   ` Martin Becze
2019-09-26  9:37     ` Ludovic Courtès
2019-09-26 15:20       ` [bug#37444] [PATCH v3 01/23] added go package go-github-com-mattn-go-pointer Martin Becze
2019-09-26 15:20         ` [bug#37444] [PATCH v3 02/23] added go package go-github-com-danwakefield-fnmatch Martin Becze
2019-09-26 15:20         ` [bug#37444] [PATCH v3 03/23] added go package go-github-com-ddevault-go-libvterm Martin Becze
2019-09-26 15:20         ` [bug#37444] [PATCH v3 04/23] added go package go-github-com-emersion-go-imap Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 05/23] added go package go-github-com-emersion-go-sasl Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 06/23] add go package go-github-com-emersion-go-imap-idle Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 07/23] added go package go-github-com-emersion-go-maildir Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 08/23] added go package go-github-com-emersion-go-message Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 09/23] added go package go-github-com-emersion-go-textwrapper Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 10/23] added go package go-github-com-emersion-go-smtp Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 11/23] added go package go-github-com-fsnotify-fsnotify Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 12/23] added go package go-github-com-go-ini-ini Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 13/23] added go package go-github-com-google-shlex Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 14/23] added go package go-github-com-kyoh86-xdg Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 15/23] added go package go-github-com-martinlindhe-base36 Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 16/23] added go package go-github-com-miolini-datacounter Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 17/23] added go package go-github-com-riywo-loginshell Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 18/23] added go package go-git-sr-ht-sircmpwn-getopt Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 19/23] added go package go-git-sr-ht-sircmpwn-pty Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 20/23] added go package go-git-sr-ht-sircmpwn-tcell Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 21/23] added aerc, a simple email client Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 22/23] updated go-github-com-mitchellh-go-homedir to version 1.1.0 Martin Becze
2019-09-26 15:21         ` [bug#37444] [PATCH v3 23/23] progagated inputs for gdamore-encoding, since this is a source only package and the go compiler needs its dependency when used as an input in another package Martin Becze
2019-10-01 21:34       ` Martin Becze [this message]
2019-10-01 21:37         ` [bug#37444] [PATCH v4 01/24] added go package go-golang-org-x-oauth2 Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 02/24] added go package go-github-com-mattn-go-pointer Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 03/24] added go package go-github-com-danwakefield-fnmatch Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 04/24] added go package go-github-com-ddevault-go-libvterm Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 05/24] added go package go-github-com-emersion-go-imap Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 06/24] added go package go-github-com-emersion-go-sasl Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 07/24] add go package go-github-com-emersion-go-imap-idle Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 08/24] added go package go-github-com-emersion-go-maildir Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 09/24] added go package go-github-com-emersion-go-message Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 10/24] added go package go-github-com-emersion-go-textwrapper Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 11/24] added go package go-github-com-emersion-go-smtp Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 12/24] added go package go-github-com-fsnotify-fsnotify Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 13/24] added go package go-github-com-go-ini-ini Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 14/24] added go package go-github-com-google-shlex Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 15/24] added go package go-github-com-kyoh86-xdg Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 16/24] added go package go-github-com-martinlindhe-base36 Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 17/24] added go package go-github-com-miolini-datacounter Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 18/24] added go package go-github-com-riywo-loginshell Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 19/24] added go package go-git-sr-ht-sircmpwn-getopt Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 20/24] added go package go-git-sr-ht-sircmpwn-pty Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 21/24] added go package go-git-sr-ht-sircmpwn-tcell Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 22/24] added aerc, a simple email client Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 23/24] updated go-github-com-mitchellh-go-homedir to version 1.1.0 Martin Becze
2019-10-01 21:37           ` [bug#37444] [PATCH v4 24/24] progagated inputs for gdamore-encoding, since this is a source only package and the go compiler needs its dependency when used as an input in another package Martin Becze
2019-09-18 15:36 ` [bug#37444] [PATCH v2 1/4] Added the dependcies for aerc. NOTE i tried to place depency authors next to each other Martin Becze
2019-09-18 15:36   ` [bug#37444] [PATCH v2 2/4] added aerc, a simple email client Martin Becze
2019-09-18 15:36   ` [bug#37444] [PATCH v2 3/4] updated go-github-com-mitchellh-go-homedir to version 1.1.0 Martin Becze
2019-09-18 15:36   ` [bug#37444] [PATCH v2 4/4] progagated inputs for gdamore-encoding, since this is a source only package and the go compiler needs its dependency when used as an input in another package Martin Becze
2022-06-11 20:10 ` [bug#37444] [PATCH] added aerc, a simple email client and its dependcies ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4c7b0d6ed94267bb60103a78b71b02c@riseup.net \
    --to=mjbecze@riseup.net \
    --cc=37444@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.