From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFPnW-0001l0-RF for guix-patches@gnu.org; Tue, 01 Oct 2019 17:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFPnU-0006iP-Q8 for guix-patches@gnu.org; Tue, 01 Oct 2019 17:35:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFPnU-0006hJ-1h for guix-patches@gnu.org; Tue, 01 Oct 2019 17:35:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFPnR-00075S-RL for guix-patches@gnu.org; Tue, 01 Oct 2019 17:35:03 -0400 Subject: [bug#37444] [PATCH] added aerc, a simple email client and its dependcies Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Tue, 01 Oct 2019 14:34:30 -0700 From: Martin Becze In-Reply-To: <87blv7pfdi.fsf@gnu.org> References: <20190918082313.3514-1-mjbecze@riseup.net> <87woe6nfka.fsf@elephly.net> <574a6c68d80bb669bbbaac7ebede8f9c@riseup.net> <87blv7pfdi.fsf@gnu.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , 37444@debbugs.gnu.org On 2019-09-26 09:37, Ludovic Courtès wrote: > Hi Martin, > > Martin Becze skribis: > >> On 2019-09-18 09:01, Ricardo Wurmus wrote: >>> Hi Martin, >>> >>>> This adds aerc, which is a terminal based email client written in go. >>> >>> Thank you for your patch! >>> >>> Could you please separate the independent changes into separate commits >>> and add commit summaries? For example, the update of >>> go-github-com-mitchellh-go-homedir should be done separately. >>> >>> Please also explain why “inputs” had to be changed to >>> “propagated-inputs” in some packages, and mention these kind of changes >>> in the commit summary. >>> >>> Thanks! >> >> just bumping, updated patch has been made and split into commits now. >> https://issues.guix.gnu.org/issue/37444 let me know if that is ok > > Like Ricardo mentioned, it would be great if patch #1 were split into > several commits, one per new package. That’s how we usually do it. > > I saw your commit logs provide explanations. However, they are all on > the “subject line” of the commit log. Could you take a look at > > regarding the format of commit logs, or run, say, “git log > gnu/packages/golang.scm” to view examples? > > I could do these changes on your behalf, but I’d rather let you do it to > make sure I don’t mess up or misrepresent what you did! > > Thanks, > Ludo’. ohhh i think i finally figured it out. (but not how to use add-change-log-entry, it looks like ppl are using that to generate the messages somehow?) anyways, v4 incoming!