From: Tobias Geerinckx-Rice <me@tobias.gr>
To: guix-devel@gnu.org
Cc: Guix-devel <guix-devel-bounces+me=tobias.gr@gnu.org>
Subject: Re: [PATCH v2] gnu: Add lrzip.
Date: Thu, 21 Jul 2016 22:31:55 +0200 [thread overview]
Message-ID: <a482e23e3702fc74d75cedf20d1f009c@tobias.gr> (raw)
In-Reply-To: <20160721202430.31332-1-me@tobias.gr>
Talking to myself,
On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
> + (native-inputs
> + `(,@(if (string-prefix? "i686" (or (%current-target-system)
> + (%current-system)))
> + `(("nasm" ,nasm))
> + '())
Hmm. Not sure where this falls on the ‘let the code speak for itself’
to ‘should have added a comment’ scale.
Guess I'll wait for another review + patch or a very friendly committer.
Kind regards,
T G-R
next prev parent reply other threads:[~2016-07-21 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 22:54 [PATCH] gnu: Add lrzip Tobias Geerinckx-Rice
2016-07-21 5:24 ` Eric Bavier
2016-07-21 17:46 ` Tobias Geerinckx-Rice
2016-07-21 20:21 ` Tobias Geerinckx-Rice
2016-07-21 20:24 ` [PATCH v2] " Tobias Geerinckx-Rice
2016-07-21 20:31 ` Tobias Geerinckx-Rice [this message]
2016-07-22 13:13 ` Ludovic Courtès
2016-07-23 10:45 ` Ludovic Courtès
2016-07-23 19:05 ` Tobias Geerinckx-Rice
2016-07-24 21:36 ` Ludovic Courtès
2016-07-24 21:56 ` Leo Famulari
2016-07-25 8:20 ` Ludovic Courtès
2016-07-24 22:34 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a482e23e3702fc74d75cedf20d1f009c@tobias.gr \
--to=me@tobias.gr \
--cc=guix-devel-bounces+me=tobias.gr@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.