all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#69634] [PATCH] gnu: hypre: don't run test phase when tests? is false
@ 2024-03-08 11:08 Lars Bilke
  2024-03-12 11:54 ` bug#69634: " Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Lars Bilke @ 2024-03-08 11:08 UTC (permalink / raw)
  To: 69634; +Cc: Lars Bilke, Andreas Enge, Eric Bavier, Sharlatan Hellseher

Without this patch it is not possible to build hypre with --tune on
machines which do not support the architecture to optimize for. The
check phase no honors the tests? property.

Change-Id: I475fabd7d9f73ed320b97a4767830d82190c2b15
---
 gnu/packages/maths.scm | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1f61ee0583..6b3a5e2e55 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -7135,16 +7135,21 @@ (define-public hypre
            (lambda _
              (invoke "make" "-C" "docs")))
          (replace 'check
-           (lambda _
-             (setenv "LD_LIBRARY_PATH" (string-append (getcwd) "/hypre/lib"))
-             (setenv "PATH" (string-append "." ":" (getenv "PATH")))
-             (invoke "make" "check" "CHECKRUN=")
-             (for-each (lambda (filename)
-                         (let ((size (stat:size (stat filename))))
-                           (when (positive? size)
-                             (error (format #f "~a size ~d; error indication~%"
-                                            filename size)))))
-                       (find-files "test" ".*\\.err$"))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (setenv "LD_LIBRARY_PATH"
+                       (string-append (getcwd) "/hypre/lib"))
+               (setenv "PATH"
+                       (string-append "." ":"
+                                      (getenv "PATH")))
+               (invoke "make" "check" "CHECKRUN=")
+               (for-each (lambda (filename)
+                           (let ((size (stat:size (stat filename))))
+                             (when (positive? size)
+                               (error (format #f
+                                       "~a size ~d; error indication~%"
+                                       filename size)))))
+                         (find-files "test" ".*\\.err$")))))
          (add-after 'install 'install-docs
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Custom install because docs/Makefile doesn't honor ${docdir}.

base-commit: 75bad75367fcf2c289fae3b40dbcc850f92177be
-- 
2.43.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#69634: [PATCH] gnu: hypre: don't run test phase when tests? is false
  2024-03-08 11:08 [bug#69634] [PATCH] gnu: hypre: don't run test phase when tests? is false Lars Bilke
@ 2024-03-12 11:54 ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2024-03-12 11:54 UTC (permalink / raw)
  To: Lars Bilke; +Cc: Andreas Enge, 69634-done, Sharlatan Hellseher, Eric Bavier

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Thanks. Patch pushed!

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-12 11:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-08 11:08 [bug#69634] [PATCH] gnu: hypre: don't run test phase when tests? is false Lars Bilke
2024-03-12 11:54 ` bug#69634: " Efraim Flashner

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.