From: Efraim Flashner <efraim@flashner.co.il>
To: David Elsing <david.elsing@posteo.net>
Cc: 68346-done@debbugs.gnu.org, Jaeme Sifat <jaeme@runbox.com>
Subject: bug#68346: [PATCH 0/2] semver aware cargo refresh
Date: Tue, 16 Jan 2024 14:26:21 +0200 [thread overview]
Message-ID: <ZaZ17dDKOuBLQJup@3900XT> (raw)
In-Reply-To: <86mst8vzwc.fsf@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On Sun, Jan 14, 2024 at 12:54:27PM +0000, David Elsing wrote:
> Hello,
>
> Efraim Flashner <efraim@flashner.co.il> writes:
> > These patches make 'guix refresh' take into account the semver of the
> > crate and only suggest upgrading to one which still matches the semver
> > constraints and isn't yanked. Then I went and used the functions to
> > factor out some of the other code.
>
> thanks for cleaning this up a bit! I tested your patches and only found
> the (minor) issue that an exception is thrown instead of returning #f if
> there is no non-yanked package available. The minimum element can also
> be found without sorting, so I would suggest something like the
> following changes:
I still think I like sort better, but it definitely doesn't do as good a
job of taking care of the #f case as your code does. I incorporated
your changes and pushed them.
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-01-16 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:05 [bug#68346] [PATCH 0/2] semver aware cargo refresh Efraim Flashner
2024-01-09 13:07 ` [bug#68346] [PATCH 1/2] import: crate: Update to latest semver version Efraim Flashner
2024-01-09 13:07 ` [bug#68346] [PATCH 2/2] import: crate: Simplify find-crate-version Efraim Flashner
2024-01-14 12:54 ` [bug#68346] [PATCH 0/2] semver aware cargo refresh David Elsing
2024-01-16 12:26 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaZ17dDKOuBLQJup@3900XT \
--to=efraim@flashner.co.il \
--cc=68346-done@debbugs.gnu.org \
--cc=david.elsing@posteo.net \
--cc=jaeme@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.