all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: cage <cage-dev@twistfold.it>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 65097@debbugs.gnu.org, cage <cage-dev@twistfold.it>
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Date: Tue, 5 Sep 2023 19:11:05 +0200	[thread overview]
Message-ID: <ZPdhKeY/wJgF6/Gi@shimizu.casa.net> (raw)
In-Reply-To: <87msy0k8ex.fsf@gmail.com>

On Tue, Sep 05, 2023 at 10:21:26AM -0400, you wrote:
> Hi!

Hi!

[…]

Thank you very much for your accurate review of this patch!

I am going to address the  issues you highlighted in your messages and
updating the patch.

I have just a question:

> > the package will skips the test (it complains "tk" can not be found");

> It'd be best to say so in the package, with a XXX comment (meaning
> subpar/hackish/dirty) like:
>
> #:tests #f   ;tests fails with "tk" can not be found error

I am  OK with this change  but I would  rather prefer to not  skip the
tests, if possible; do you have any suggestions about making the build
environment find the tk executable?

Thanks again for your help!
C.




  parent reply	other threads:[~2023-09-05 17:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05 13:45 [bug#65097] [PATCH] gnu: Add tk-img cage
2023-09-05 14:21 ` Maxim Cournoyer
2023-09-05 14:43   ` Maxim Cournoyer
2023-09-05 17:11   ` cage [this message]
2023-09-05 14:22 ` Maxim Cournoyer
2023-09-06 14:06 ` cage
2023-09-06 16:06   ` Maxim Cournoyer
2023-09-06 17:42     ` cage
2023-11-16 15:39 ` [bug#65097] failed attempt cage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPdhKeY/wJgF6/Gi@shimizu.casa.net \
    --to=cage-dev@twistfold.it \
    --cc=65097@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.