all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: cage <cage-dev@twistfold.it>
To: 65097@debbugs.gnu.org
Cc: maxim.cournoyer@gmail.com
Subject: [bug#65097] [PATCH] gnu: Add tk-img.
Date: Wed, 6 Sep 2023 16:06:59 +0200	[thread overview]
Message-ID: <2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@twistfold.it> (raw)
In-Reply-To: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@twistfold.it>

Hi!

With this patch I tried to address all the issues that was pointed out
(hope they are fine :)) except one:

> One last thing, the source of tk-img carries many 'contrib' sources;
> they should be removed in a snippet to ensure only Guix-provided system
> libraries are used instead.

Because I was not able to find out the contribs sources.

Also, for the record, the problem with  tests is not that the Tk (as I
erroneously thought)  executable can not  be found but that,  for some
reasons, the tcl script seems to fails to resolve Tk as dependency:

$ tclsh

% package require Tk → raise an error

the same line works on my other system (Debian)

Bye!
C.

---
 gnu/packages/tcl.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm
index b69dba2254..22602c177a 100644
--- a/gnu/packages/tcl.scm
+++ b/gnu/packages/tcl.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tcl)
   #:use-module (gnu packages)
   #:use-module (gnu packages image)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
@@ -509,3 +510,42 @@ (define-public go-github.com-nsf-gothic
     (description "Gothic contains Go bindings for Tcl/Tk.  The package contains
 only one type and one function that can be used to create a Tk interpreter.")
     (license license:expat))))
+
+(define-public tk-img
+  (package
+    (name "tk-img")
+    (version "1.4.14")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/tkimg/tkimg/1.4/tkimg%20"
+             version
+             "/Img-" version "-Source.tar.gz"))
+       (file-name (string-append "tkimg-" version ".tar.gz"))
+       (sha256
+        (base32 "08dvb8bfkxr919wp6fq14cfb9lz1v59jx1la4a6j4ks636wb243m"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f ; tests fails because the tcl shell can not find Tk ("package require Tk" fails)
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (invoke "make" "install-libraries"))))
+           #:configure-flags
+           #~(list
+              (string-append "--exec-prefix=" #$output)
+              (string-append "--with-tcl="
+                             (assoc-ref %build-inputs "tcl") "/lib")
+              (string-append "--with-tk="
+                             (assoc-ref %build-inputs "tk") "/lib"))))
+    (native-inputs
+     (list tcl tk ghostscript))
+    (home-page "https://sourceforge.net/projects/tkimg/")
+    (synopsis "Increase the number bitmap file formats supported by TK.")
+    (description
+     "The Img package adds supports for several image formats to TCl/TK; notably JPEG, ICO, BMP, TGA and PostScript (using an external PostScript interpreter).")
+    (license (license:non-copyleft
+              "file://license.terms"
+              "See license.terms in the distribution."))))

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
--
2.34.0




  parent reply	other threads:[~2023-09-06 14:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05 13:45 [bug#65097] [PATCH] gnu: Add tk-img cage
2023-09-05 14:21 ` Maxim Cournoyer
2023-09-05 14:43   ` Maxim Cournoyer
2023-09-05 17:11   ` cage
2023-09-05 14:22 ` Maxim Cournoyer
2023-09-06 14:06 ` cage [this message]
2023-09-06 16:06   ` Maxim Cournoyer
2023-09-06 17:42     ` cage
2023-11-16 15:39 ` [bug#65097] failed attempt cage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a54087d189965c4a6ee73d8b24b3b594bb0d5f4.1694008299.git.cage-dev@twistfold.it \
    --to=cage-dev@twistfold.it \
    --cc=65097@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.