all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 61583@debbugs.gnu.org, ludo@gnu.org,
	Greg Hogan <code@greghogan.com>,
	zimoun <zimon.toutoune@gmail.com>
Subject: [bug#61583] [PATCH] gnu: git: Update to 2.39.2 [fixes CVE-2023-22490 & CVE-2023-23946].
Date: Sun, 5 Mar 2023 14:30:45 -0500	[thread overview]
Message-ID: <ZATt5Qs2aEbUArVt@jasmine.lan> (raw)
In-Reply-To: <87bkl8qu85.fsf@jpoiret.xyz>

> "Leo Famulari" <leo@famulari.name> writes:
> > Changing the Git package shouldn't affect fixed-output derivations that fetch from Git. If they do, that's a recent and very serious bug.

Now I have confused myself and I'm unsure. I stepped away from Guix for
a while and forgot a lot of the intimate knowledge I had on this
subject.

I checked, and this patch does change the derivation of packages
fetching from Git, although the output is identical. So, I am confused
about if this will cause >10k rebuilds or not.

Here's how I checked, first by calculating derivations and outputs on
the master branch, and then after applying the patch:

------
$ git rev-parse --abbrev-ref HEAD
master
$ git rev-parse HEAD                                 
cedf97ed6ee4eba8c39bfe6cc0efe33fcb977ccf
$ ./pre-inst-env guix build --no-grafts corefreq -d
/gnu/store/78lhq407x6sjlf3k7jh16ph1pff1y2nw-corefreq-1.95.2.drv    
$ ./pre-inst-env guix build --no-grafts corefreq   
/gnu/store/vva0xljihzmpf4ddbihr168f2ymkh2k0-corefreq-1.95.2-linux-module
/gnu/store/qkwah5gnfqh293i36byhc00cd6xb3jml-corefreq-1.95.2
------

Apply the patch:

------
$ git checkout contrib-security-git                 
Switched to branch 'contrib-security-git'
$ git log --oneline | head -n1         
faeb52692d gnu: git: Update to 2.39.2 [fixes CVE-2023-22490 & CVE-2023-23946].
$ ./pre-inst-env guix build --no-grafts corefreq -d
/gnu/store/sw5942gj4f5lm9i9zn6bwj7f0q0dlf7a-corefreq-1.95.2.drv         
$ ./pre-inst-env guix build --no-grafts corefreq   
/gnu/store/vva0xljihzmpf4ddbihr168f2ymkh2k0-corefreq-1.95.2-linux-module
/gnu/store/qkwah5gnfqh293i36byhc00cd6xb3jml-corefreq-1.95.2
------

The package derivation changed, but not the output.

I'm looking for guidance on how to interpret these results.




  reply	other threads:[~2023-03-05 19:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 18:04 [bug#61583] [PATCH] gnu: git: Update to 2.39.2 [fixes CVE-2023-22490 & CVE-2023-23946] Greg Hogan
2023-02-20 11:44 ` Simon Tournier
2023-03-03 19:14   ` Simon Tournier
2023-03-03 19:33     ` Tobias Geerinckx-Rice via Guix-patches via
2023-03-04  3:39     ` Maxim Cournoyer
2023-03-04  3:44       ` Leo Famulari
2023-03-03 21:56   ` Leo Famulari
2023-03-04 10:30     ` Josselin Poiret via Guix-patches via
2023-03-04 14:41       ` Leo Famulari
2023-03-04 15:34         ` Tobias Geerinckx-Rice via Guix-patches via
2023-03-06 12:54           ` Maxim Cournoyer
2023-03-04 17:52         ` Josselin Poiret via Guix-patches via
2023-03-05 19:30           ` Leo Famulari [this message]
2023-03-04 18:52     ` Simon Tournier
2023-03-05 18:45       ` Leo Famulari
2023-03-05 19:27         ` Christopher Baines
2023-03-05 20:33         ` Simon Tournier
2023-03-06 17:23 ` bug#61583: " Leo Famulari
2023-03-08  9:50   ` [bug#61583] " Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZATt5Qs2aEbUArVt@jasmine.lan \
    --to=leo@famulari.name \
    --cc=61583@debbugs.gnu.org \
    --cc=code@greghogan.com \
    --cc=dev@jpoiret.xyz \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.